From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932740AbbCQQcy (ORCPT ); Tue, 17 Mar 2015 12:32:54 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:57395 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932558AbbCQQcw (ORCPT ); Tue, 17 Mar 2015 12:32:52 -0400 Message-ID: <550856FF.9080702@ti.com> Date: Tue, 17 Mar 2015 11:31:59 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: santosh shilimkar , Tony Lindgren , Stefan Hengelein CC: , , , , Subject: Re: [PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688 References: <1424889867-8980-1-git-send-email-stefan.hengelein@fau.de> <20150316233005.GA2598@atomide.com> <550855B7.3020905@oracle.com> In-Reply-To: <550855B7.3020905@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/17/2015 11:26 AM, santosh shilimkar wrote: > > > On 3/16/2015 4:30 PM, Tony Lindgren wrote: >> * Stefan Hengelein [150225 10:48]: >>> The Kconfig-Option OMAP4_ERRATA_I688 is never visible due to a >>> contradiction in it's dependencies. >>> The option requires ARCH_MULTIPLATFORM to be 'disabled'. However, an >>> enclosing menu requires either ARCH_MULTI_V6 or ARCH_MULTI_V7 to be >>> enabled. These options inherit a dependency from an enclosing menu, >>> that requires ARCH_MULTIPLATFORM to be 'enabled'. >>> This is a contradiction and made this option also unavailable for >>> non-multiplatform configurations. >>> >>> Since there are no selects on OMAP4_ERRATA_I688, which would ignore >>> dependencies, the code related to that option is dead and can be >>> removed. >>> >>> This (logical) defect has been found with the undertaker tool. >>> (https://undertaker.cs.fau.de) >>> >>> Signed-off-by: Stefan Hengelein >>> >>> --- >>> Tony Lindgren suggested to remove the code since nobody complained for >>> a few years and Santosh Shilimkar agreed. >>> https://lkml.org/lkml/2015/2/25/449 >>> --- >>> As far as I see, this should remove all the code related to >>> OMAP4_ERRATA_I688, I hope I didn't remove too much. >> >> Seems to boot fine, so applying into omap-for-v4.1/fixes-not-urgent. >> > Acked-by: Santosh Shilimkar We no longer need i688? I do understand the need to cleanup the macros for multi-arch etc.. but loosing a bug workaround for a real silicon bug is really an invitation for hard to debug issues IMHO. -- Regards, Nishanth Menon