From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932987AbbCQReF (ORCPT ); Tue, 17 Mar 2015 13:34:05 -0400 Received: from mail.kernel.org ([198.145.29.136]:41959 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754373AbbCQReB (ORCPT ); Tue, 17 Mar 2015 13:34:01 -0400 Message-ID: <55086581.3010106@kernel.org> Date: Wed, 18 Mar 2015 02:33:53 +0900 From: Kukjin Kim User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.16 MIME-Version: 1.0 To: Krzysztof Kozlowski CC: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Olof Johansson , Marek Szyprowski , Pankaj Dubey Subject: Re: [PATCH v4 1/3] ARM: EXYNOS: Add missing static to file-scope declarations References: <1426072121-6822-1-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1426072121-6822-1-git-send-email-k.kozlowski@samsung.com> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/15 20:08, Krzysztof Kozlowski wrote: > The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs' > and 'exynos5420_release_ret_regs' are not exported nor used outside of > suspend.c file. Make them static. > > This fixes following sparse warnings: > arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static? > arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static? > arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static? > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Pankaj Dubey > --- Applied this whole series. Thanks, Kukjin