From: Michal Marek <mmarek@suse.cz>
To: Sylvain BERTRAND <sylvain.bertrand@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
Date: Tue, 17 Mar 2015 21:59:13 +0100 [thread overview]
Message-ID: <550895A1.1000901@suse.cz> (raw)
In-Reply-To: <20150303163453.GA21318@localhost.localdomain>
Dne 3.3.2015 v 17:34 Sylvain BERTRAND napsal(a):
> On Fri, Jan 02, 2015 at 04:55:42PM +0100, Michal Marek wrote:
>> On 2014-12-29 17:34, Sylvain BERTRAND wrote:
>>> Chocked while compiling linux with dash shell instead of bash shell.
>>> See:
>>> http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
>>
>> Please describe the actual problem in the changelog. I guess it's
>> because of the 'ERR' trap?
>
> Indeed:
> - ERR is specific to bash
> - signal names in a trap built-in instruction should be without the SIG prefix
>
> Shall I repost a v2 with the above lines?
Sorry if I wasn't clear. The changelog should contain the actual error
message or description of wrong behavior when ran under dash.
Michal
next prev parent reply other threads:[~2015-03-17 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 16:34 [PATCH] scripts: fix link-vmlinux.sh bash-ism Sylvain BERTRAND
2015-01-02 15:55 ` Michal Marek
2015-03-03 16:34 ` Sylvain BERTRAND
2015-03-17 20:59 ` Michal Marek [this message]
2015-04-27 15:25 ` sylvain.bertrand
2015-05-06 13:54 ` sylvain.bertrand
2015-05-06 14:25 ` Michal Marek
2015-05-07 0:36 ` [PATCH v2] " sylvain.bertrand
2015-05-07 11:58 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550895A1.1000901@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sylvain.bertrand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox