From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932358AbbCQWkl (ORCPT ); Tue, 17 Mar 2015 18:40:41 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:54894 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbbCQWkg (ORCPT ); Tue, 17 Mar 2015 18:40:36 -0400 X-AuditID: cbfee68d-f79296d000004278-db-5508ad61de76 Message-id: <5508AD61.1060005@samsung.com> Date: Wed, 18 Mar 2015 07:40:33 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Ingi Kim , cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org Cc: sakari.ailus@iki.fi, j.anaszewski@samsung.com, varkabhadram@gmail.com, sw0312.kim@samsung.com, cw00.choi@samsung.com, ideal.song@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 2/3] leds: ktd2692: add device tree bindings for ktd2692 References: <1426581951-11869-1-git-send-email-ingi2.kim@samsung.com> <1426581951-11869-3-git-send-email-ingi2.kim@samsung.com> In-reply-to: <1426581951-11869-3-git-send-email-ingi2.kim@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWyRsSkSDdxLUeowYOLphZHd05ksrj+5Tmr xfwj51gt+t8sZLXY9fc+o8W5VysZLXbc/MJm0Xv1OaPF5V1z2Cy2vlnHaLH0+kUmiwnT17JY tO49wm6xe9dTVosz+1eyWcyY/JLN4mTHHEYHQY8189Ywelzu62Xy2DnrLrvHyuVf2DwOf13I 4rFpVSebx575P1g9+rasYvT4vEkugDOKyyYlNSezLLVI3y6BK2Pmv8lsBW2CFXcuzWJuYPzD 28XIySEhYCJxcMFhJghbTOLCvfVsXYxcHEICSxkl/rTsZIYpOnNkHTtEYhGjxMav6xghnNeM EnfPbGDtYuTg4BXQkng0hwOkgUVAVWL7/ntgU9kEdCS2fzsOZosKhElMvPmYFcTmFRCU+DH5 HgvIHBGBQ4wSJw/NAdvGLPCGUWJyQzSILSzgLzFhSxPUskZGifbPR5hBlnEKuEk0L/UCMZkF 9CTuX9SCaJWX2LzmLTNIuYTAHg6Jaev+MkIcJCDxbfIhFpB6CQFZiU0HoB6TlDi44gbLBEax WUhOmoUwdRaSqQsYmVcxiqYWJBcUJ6UXGeoVJ+YWl+al6yXn525iBCaA0/+e9e5gvH3A+hCj AAejEg9vQx57qBBrYllxZe4hRlOgIyYyS4km5wPTTF5JvKGxmZGFqYmpsZG5pZmSOK+i1M9g IYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYwRnLK8xc2Rt1T1Xt8/OHVy9mt2z+ab+3cl3phk IrCGZXfYF8vsiO/Z9v4zjwT+Dfy5Pyd9W2jlwoe+B5olxXvui045d/FKzu+bNz/ERyRXL38W t8K8cMb0LTIXBDW0PFSSG7P+H/nsWSjxqvecvylb2w62+3o7xOx/hnP+u1i68q9M59vs3cJK LMUZiYZazEXFiQD04rRd+wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsVy+t9jAd3EtRyhBlNbdSyO7pzIZHH9y3NW i/lHzrFa9L9ZyGqx6+99Rotzr1YyWuy4+YXNovfqc0aLy7vmsFlsfbOO0WLp9YtMFhOmr2Wx aN17hN1i966nrBZn9q9ks5gx+SWbxcmOOYwOgh5r5q1h9Ljc18vksXPWXXaPlcu/sHkc/rqQ xWPTqk42jz3zf7B69G1ZxejxeZNcAGdUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGu oaWFuZJCXmJuqq2Si0+ArltmDtA3SgpliTmlQKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM 0EDCGsaMmf8msxW0CVbcuTSLuYHxD28XIyeHhICJxJkj69ghbDGJC/fWs3UxcnEICSxilNj4 dR0jhPOaUeLumQ2sXYwcHLwCWhKP5nCANLAIqEps33+PCcRmE9CR2P7tOJgtKhAmMfHmY1YQ m1dAUOLH5HssIHNEBA4xSpw8NIcZJMEs8IZRYnJDNIgtLOAvMWFLE9SyRkaJ9s9HmEGWcQq4 STQv9QIxmQX0JO5f1IJolZfYvOYt8wRGgVlIVsxCqJqFpGoBI/MqRtHUguSC4qT0XCO94sTc 4tK8dL3k/NxNjOD08kx6B+OqBotDjAIcjEo8vA157KFCrIllxZW5QPdyMCuJ8Gq1cIQK8aYk VlalFuXHF5XmpBYfYjQFBsBEZinR5Hxg6ssriTc0NjEzsjQyN7QwMjZXEudVsm8LERJITyxJ zU5NLUgtgulj4uCUamCsjlMKyGksWNncnhK5+F/axgn6LYrPEr87ZccHJs7UT36X2DfvVfxO jXIdlw3bSrUuKbIeevR7ecO/7yt0r72tlvjGds/uzaGsVVr73od+kZ/Jce8663TB7JXqZ83z 5fiPrb26l0VfKnvJromH8zmnTHeUY1iQ9OSrVHtqs4Dc9Lsn4lm3Gs5TYinOSDTUYi4qTgQA w8QJe0UDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/17/2015 05:45 PM, Ingi Kim wrote: > This patch adds the device tree bindings for ktd2692 flash LEDs. > Add optional properties 'flash-timeout-us' to control flash timeout > and 'vin-supply' for flash-led regulator > > Signed-off-by: Ingi Kim > --- > .../devicetree/bindings/leds/leds-ktd2692.txt | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt > new file mode 100644 > index 0000000..1b44225 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt > @@ -0,0 +1,37 @@ > +* Kinetic Technologies - KTD2692 Flash LED Driver > + > +KTD2692 is the ideal power solution for high-power flash LEDs. > +It uses ExpressWire single-wire programming for maximum flexibility. > + > +The ExpressWire interface through CTRL pin can control LED on/off and > +enable/disable the IC, Movie/Flash mode current, Flash timeout, > +LVP(low voltage protection). > + > +Required properties: > + - compatible: "kinetic,ktd2692" > + - ctrl-gpio : gpio pin in order control ktd2692 flash led. > + There is an internal 300kOhm pull-down resistor at this pin > + - supply : "vin" LED supply > + > +Optional property: > + - flash-timeout-us : Maximum flash timeout in microseconds. > + flash timeout ranges from 0 to 1835000us and > + default is 1049000us. > + > +Example: > + > +vbat: fixedregulator@0 { > + compatible = "regulator-fixed"; > + regulator-name = "vbat-supply"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <>; gpio = <> ? What do you mean? And this is described at Documentation/devicetree/bindings/regulator/fixed-regulator.txt I'm not sure whether this example really needs. Best Regards, Jaehoon Chung > + regulator-always-on; > +}; > + > +flash-led { > + compatible = "kinetic,ktd2692"; > + ctrl-gpio = <&gpc0 1 0>; > + flash-timeout-us = <1835000>; > + vin-supply = <&vbat>; > +}; >