From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932902AbbCRBft (ORCPT ); Tue, 17 Mar 2015 21:35:49 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:30001 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741AbbCRBfp convert rfc822-to-8bit (ORCPT ); Tue, 17 Mar 2015 21:35:45 -0400 X-AuditID: cbfee691-f79b86d000004a5a-89-5508d66e2bae MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <5508D65F.7070301@samsung.com> Date: Wed, 18 Mar 2015 10:35:27 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 To: Jaehoon Chung Cc: cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sakari.ailus@iki.fi, j.anaszewski@samsung.com, varkabhadram@gmail.com, sw0312.kim@samsung.com, cw00.choi@samsung.com, ideal.song@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 2/3] leds: ktd2692: add device tree bindings for ktd2692 References: <1426581951-11869-1-git-send-email-ingi2.kim@samsung.com> <1426581951-11869-3-git-send-email-ingi2.kim@samsung.com> <5508AD61.1060005@samsung.com> In-reply-to: <5508AD61.1060005@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsWyRsSkWDf/GkeowaHtzBZHd05ksrj+5Tmr xfwj51gt+t8sZLXY9fc+o8W5VysZLXqvPme0uPGrjdXi8q45bBZb36xjtFh6/SKTxYTpa1ks WvceYbfYvespq8WZ/SvZLGZMfslmcbJjDqODoMeaeWsYPS739TJ57Jx1l91j5fIvbB6Hvy5k 8di0qpPNY8/8H6wefVtWMXp83iQXwBnFZZOSmpNZllqkb5fAldFyYCNzwUPhigenZzI1MM4S 6GLk5JAQMJHY9q6HGcIWk7hwbz1bFyMXh5DAUkaJv13r2GCKTvx7wwpiCwksYpSYt8McxOYV EJT4MfkeSxcjBwezgLrElCm5IGFmARGJeX+2M0LY2hLLFr5mhpj5mlFi+tIGZoheLYmOtrdg M1kEVCX23z4A1sAmoCZxY8VCJpCZogIRErcvc4KERYDKrx+ZCHYbs0AXs0Tj29ssIAlhAX+J CVuaGCEWAN12ZtpkVpBmTqDNP+45gsQlBHZwSCw4vJcJYpmAxLfJh8COlhCQldh0AOp5SYmD K26wTGAUn4XktVkIr81C8tosJK8tYGRZxSiaWpBcUJyUXmSqV5yYW1yal66XnJ+7iRGYLk7/ ezZxB+P9A9aHGAU4GJV4eG8UsIcKsSaWFVfmHmI0BTpoIrOUaHI+MCnllcQbGpsZWZiamBob mVuaKYnz6kj/DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAyD1Joe5GRWbLUzlT3vkxGUaK GrWSjo8j7p429UrVlVlYqb314yqBcDZ2Tnu2PvtJDb6fHq9dJdsow9oll1R3+Nz66le7dsea /pXMVtsacZU/XVgt0f7enAlxbEkTbtY3TowwaNt5UCuhOLbzp+/9X8lr+/x/S125Pkcx9FjN BOX3JT9+BRsrsRRnJBpqMRcVJwIAjKHOkRIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPKsWRmVeSWpSXmKPExsVy+t9jAd28axyhBn+OmVkc3TmRyeL6l+es FvOPnGO16H+zkNVi19/7jBbnXq1ktOi9+pzR4savNlaLy7vmsFlsfbOO0WLp9YtMFhOmr2Wx aN17hN1i966nrBZn9q9ks5gx+SWbxcmOOYwOgh5r5q1h9Ljc18vksXPWXXaPlcu/sHkc/rqQ xWPTqk42jz3zf7B69G1ZxejxeZNcAGdUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGu oaWFuZJCXmJuqq2Si0+ArltmDtA3SgpliTmlQKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM 0EDCGsaMbc2PWQq2C1dsP7mFpYHxA38XIyeHhICJxIl/b1ghbDGJC/fWs4HYQgKLGCXm7TAH sXkFBCV+TL7H0sXIwcEsIC9x5FI2hKkuMWVKbhcjF1D1a0aJ6UsbmCHKtSQ62t6CjWQRUJXY f/sAI4jNJqAmcWPFQiaQXlGBCInblzlBwiJA5dePTGQDmcMs0MUs0fj2NgtIQljAX2LCliZG iAVA55yZNpkVpJlTQFvixz3HCYwCs5BcNwvhulkI1y1gZF7FKJpakFxQnJSea6RXnJhbXJqX rpecn7uJEZxYnknvYFzVYHGIUYCDUYmHtyGPPVSINbGsuDL3EKMEB7OSCK9WC0eoEG9KYmVV alF+fFFpTmrxIUZToN8mMkuJJucDk15eSbyhsYmZkaWRuaGFkbG5kjivkn1biJBAemJJanZq akFqEUwfEwenVAPjNtXsLCk5Qy+5vIZs2wmCR/6vzt59zcD2mWlF9t+9B65qX9ywbvLpDb2s Se+Px7MpCU/ZlGny4EGmkYp73te2M4ULzD9q2/vd5Y2yyXm6bZPw1eDPH7RuVZ+/vXjzY+7l 8+65fnrvbW+wkvU5+/3Ucx9On4yMftydxqKj6mXNmMvcZqD8mClaiaU4I9FQi7moOBEAcYqZ QEIDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 2015년 03월 18일 07:40, Jaehoon Chung wrote: > On 03/17/2015 05:45 PM, Ingi Kim wrote: >> This patch adds the device tree bindings for ktd2692 flash LEDs. >> Add optional properties 'flash-timeout-us' to control flash timeout >> and 'vin-supply' for flash-led regulator >> >> Signed-off-by: Ingi Kim >> --- >> .../devicetree/bindings/leds/leds-ktd2692.txt | 37 ++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> new file mode 100644 >> index 0000000..1b44225 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> @@ -0,0 +1,37 @@ >> +* Kinetic Technologies - KTD2692 Flash LED Driver >> + >> +KTD2692 is the ideal power solution for high-power flash LEDs. >> +It uses ExpressWire single-wire programming for maximum flexibility. >> + >> +The ExpressWire interface through CTRL pin can control LED on/off and >> +enable/disable the IC, Movie/Flash mode current, Flash timeout, >> +LVP(low voltage protection). >> + >> +Required properties: >> + - compatible: "kinetic,ktd2692" >> + - ctrl-gpio : gpio pin in order control ktd2692 flash led. >> + There is an internal 300kOhm pull-down resistor at this pin >> + - supply : "vin" LED supply >> + >> +Optional property: >> + - flash-timeout-us : Maximum flash timeout in microseconds. >> + flash timeout ranges from 0 to 1835000us and >> + default is 1049000us. >> + >> +Example: >> + >> +vbat: fixedregulator@0 { >> + compatible = "regulator-fixed"; >> + regulator-name = "vbat-supply"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + gpio = <>; > > gpio = <> ? What do you mean? > And this is described at Documentation/devicetree/bindings/regulator/fixed-regulator.txt > I'm not sure whether this example really needs. > > Best Regards, > Jaehoon Chung > I just want to show that dummy regulator can be used with flash-led. As you mentioned earlier, remove unnecessary example and add refer comment Thanks, Ingi Kim >> + regulator-always-on; >> +}; >> + >> +flash-led { >> + compatible = "kinetic,ktd2692"; >> + ctrl-gpio = <&gpc0 1 0>; >> + flash-timeout-us = <1835000>; >> + vin-supply = <&vbat>; >> +}; >> > >