From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932691AbbCRM1Z (ORCPT ); Wed, 18 Mar 2015 08:27:25 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:47597 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756107AbbCRM1V (ORCPT ); Wed, 18 Mar 2015 08:27:21 -0400 Message-ID: <55096F23.10302@atmel.com> Date: Wed, 18 Mar 2015 13:27:15 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Hans-Christian Egtvedt , Ben Dooks CC: , Linux Networking List , Arun Chandran , "Haavard Skinnemoen" , Linux Kernel List Subject: Re: [PATCH] net: macb: fix endian code for avr32 References: <1426676247-14023-1-git-send-email-ben.dooks@codethink.co.uk> <20150318122538.GA19497@samfundet.no> In-Reply-To: <20150318122538.GA19497@samfundet.no> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/03/2015 13:25, Hans-Christian Egtvedt a écrit : > Around Wed 18 Mar 2015 10:57:27 +0000 or thereabout, Ben Dooks wrote: >> [note this has yet to be compile tested on avr32] >> > > Compiles fine without warnings. > >> The changes to run the macb driver in 29af05aeb98e ("net: macb: >> Add big endian CPU support") to support big endian operation on >> ARM may not work on AVR32 which already is naturally big endian >> architecture (and the driver already works here). > > The 29af05aeb98e will brick the macb driver for AVR32, as readZ_relaxed > translates to readZ calls, which turns into le_to_cpu reads. > >> In this case the readl/writel relaxed will do the opposite of __raw >> accesors which arleady work. Add an indirection of cdneth_ prefixed >> accesors which are changed as necessary. Also do not issue the DMA >> descritpor endian fetch configuration for AVR32. >> >> From discussions with Arnd Bergman, the following fix changes the use >> of readl_relaxed and writel_relaxed with a version that can be put >> back to __raw_readl/__raw_writel for the CONFIG_AVR32 case (and also >> remove the change to the DMA descriptor endian). > > Thank you for spotting this. > >> Signed-off-by: Ben Dooks >> Reported-by: Arnd Bergmann > > Acked-by: Hans-Christian Egtvedt Acked-by: Nicolas Ferre >> -- >> CC: Linux Networking List >> CC: Arun Chandran >> CC: Haavard Skinnemoen >> CC: Hans-Christian Egtvedt >> CC: Linux Kernel List >> CC: Nicolas Ferre >> --- >> drivers/net/ethernet/cadence/macb.c | 14 +++++++------- >> drivers/net/ethernet/cadence/macb.h | 20 ++++++++++++++------ >> 2 files changed, 21 insertions(+), 13 deletions(-) > > > -- Nicolas Ferre