From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756648AbbCRNo2 (ORCPT ); Wed, 18 Mar 2015 09:44:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56541 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755853AbbCRNo1 (ORCPT ); Wed, 18 Mar 2015 09:44:27 -0400 Message-ID: <55098139.7090206@suse.cz> Date: Wed, 18 Mar 2015 14:44:25 +0100 From: Vlastimil Babka User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Fabian Frederick , linux-kernel@vger.kernel.org CC: linux-mm@kvack.org Subject: Re: [PATCH 1/1 linux-next] mm/page_alloc.c: don't redeclare mt in get_pageblock_migratetype() References: <1426097333-24131-1-git-send-email-fabf@skynet.be> In-Reply-To: <1426097333-24131-1-git-send-email-fabf@skynet.be> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2015 07:08 PM, Fabian Frederick wrote: > mt is already declared above and global value not used after loop. > This fixes a shadow warning. > > Signed-off-by: Fabian Frederick Acked-by: Vlastimil Babka > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 1b84950..4ec8c23 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1653,7 +1653,7 @@ int __isolate_free_page(struct page *page, unsigned int order) > if (order >= pageblock_order - 1) { > struct page *endpage = page + (1 << order) - 1; > for (; page < endpage; page += pageblock_nr_pages) { > - int mt = get_pageblock_migratetype(page); > + mt = get_pageblock_migratetype(page); > if (!is_migrate_isolate(mt) && !is_migrate_cma(mt)) > set_pageblock_migratetype(page, > MIGRATE_MOVABLE); >