From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755208AbbCROqv (ORCPT ); Wed, 18 Mar 2015 10:46:51 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:35100 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120AbbCROqt (ORCPT ); Wed, 18 Mar 2015 10:46:49 -0400 Message-ID: <55098FD4.7080902@cogentembedded.com> Date: Wed, 18 Mar 2015 17:46:44 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Heikki Krogerus , Felipe Balbi CC: Greg Kroah-Hartman , David Cohen , Stephen Boyd , Baolu Lu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I Subject: Re: [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering References: <1426682433-133813-1-git-send-email-heikki.krogerus@linux.intel.com> <1426682433-133813-12-git-send-email-heikki.krogerus@linux.intel.com> In-Reply-To: <1426682433-133813-12-git-send-email-heikki.krogerus@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 3/18/2015 3:40 PM, Heikki Krogerus wrote: > ULPI PHYs need to be bound to their controllers with a > lookup. This adds helpers that the ULPI drivers can use to > do both, the registration of the PHY and the lookup, at the > same time. > Signed-off-by: Heikki Krogerus > Cc: Kishon Vijay Abraham I > --- > drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 drivers/phy/ulpi_phy.h > diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h > new file mode 100644 > index 0000000..ac49fb6 > --- /dev/null > +++ b/drivers/phy/ulpi_phy.h > @@ -0,0 +1,31 @@ > +#include > + > +/** > + * Helper that registers PHY for a ULPI device and adds a lookup for binding it > + * and it's controller, which is always the parent. > + */ > +static inline struct phy > +*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops) Please either keep the prototype on a single line or don't break it like this. The result type should be all on the 1st line. [...] WBR, Sergei