From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754797AbbCRPAr (ORCPT ); Wed, 18 Mar 2015 11:00:47 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:33893 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbbCRPAo (ORCPT ); Wed, 18 Mar 2015 11:00:44 -0400 Message-ID: <55099318.3010609@cogentembedded.com> Date: Wed, 18 Mar 2015 18:00:40 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Robert Baldyga , balbi@ti.com CC: gregkh@linuxfoundation.org, myungjoo.ham@samsung.com, cw00.choi@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com Subject: Re: [RFC 07/19] dwc3: core: cleanup suspend/resume code References: <1426687464-2563-1-git-send-email-r.baldyga@samsung.com> <1426687464-2563-8-git-send-email-r.baldyga@samsung.com> In-Reply-To: <1426687464-2563-8-git-send-email-r.baldyga@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 3/18/2015 5:04 PM, Robert Baldyga wrote: > Remove unused cases from switch-case statement and place > dwc3_event_buffers_cleanup() function outside switch-case > as it's called in each case anyway. > Signed-off-by: Robert Baldyga > --- > drivers/usb/dwc3/core.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 2bbab3d..b040ce0 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1018,13 +1018,12 @@ static int dwc3_suspend(struct device *dev) > case USB_DR_MODE_PERIPHERAL: > case USB_DR_MODE_OTG: > dwc3_gadget_suspend(dwc); > - /* FALLTHROUGH */ Why are you removing comment that stays valid? > - case USB_DR_MODE_HOST: > default: > - dwc3_event_buffers_cleanup(dwc); > break; > } > > + dwc3_event_buffers_cleanup(dwc); > + > dwc->gctl = dwc3_readl(dwc->regs, DWC3_GCTL); > spin_unlock_irqrestore(&dwc->lock, flags); > > @@ -1061,10 +1060,7 @@ static int dwc3_resume(struct device *dev) > case USB_DR_MODE_PERIPHERAL: > case USB_DR_MODE_OTG: > dwc3_gadget_resume(dwc); > - /* FALLTHROUGH */ Likewise. > - case USB_DR_MODE_HOST: > default: > - /* do nothing */ > break; > } > WBR, Sergei