From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933336AbbCRQpo (ORCPT ); Wed, 18 Mar 2015 12:45:44 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:48169 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069AbbCRQpl (ORCPT ); Wed, 18 Mar 2015 12:45:41 -0400 Message-ID: <5509AB94.8040100@st.com> Date: Wed, 18 Mar 2015 17:45:08 +0100 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Lee Jones , , , , CC: Subject: Re: [STLinux Kernel] [PATCH 5/6] pinctrl: st: Show correct pin direction -- even when in GPIO mode References: <1426675899-19882-1-git-send-email-lee.jones@linaro.org> <1426675899-19882-6-git-send-email-lee.jones@linaro.org> In-Reply-To: <1426675899-19882-6-git-send-email-lee.jones@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.23.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-03-18_05:2015-03-18,2015-03-18,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/18/2015 11:51 AM, Lee Jones wrote: > Until now ST's pinconf_dbg_show() call-back has displayed the PIO > alternate function direction, which is only relevant if a pin is > operating in an alternate function mode i.e not GPIO mode. If a > pin is in GPIO mode its direction is both set and status is > obtained by a completely different/unrelated bunch of registers. > > This change ensures that the correct pin direction is shown, even > if a pin is operating in GPIO mode. > > Reported-by: Olivier Clergeaud > Signed-off-by: Lee Jones > --- > drivers/pinctrl/pinctrl-st.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > Acked-by: Maxime Coquelin Thanks, Maxime