From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755935AbbCRRzt (ORCPT ); Wed, 18 Mar 2015 13:55:49 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:35421 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754670AbbCRRzr (ORCPT ); Wed, 18 Mar 2015 13:55:47 -0400 Message-ID: <5509BC1E.8050802@cogentembedded.com> Date: Wed, 18 Mar 2015 20:55:42 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Geert Uytterhoeven , Thomas Gleixner , Jason Cooper CC: linux-sh@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: renesas-intc-irqpin: Add optional functional clock to bindings References: <1426696644-25636-1-git-send-email-geert+renesas@glider.be> In-Reply-To: <1426696644-25636-1-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/18/2015 07:37 PM, Geert Uytterhoeven wrote: > This clock is managed since commit 705bc96c2c15313c ("irqchip: > renesas-intc-irqpin: Add minimal runtime PM support"). > Also add an example while we're at. > Signed-off-by: Geert Uytterhoeven > --- > .../interrupt-controller/renesas,intc-irqpin.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt > index 4f7946ae8adcdc04..e7cfcec056159b93 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt > @@ -25,3 +25,32 @@ Optional properties: > if different from the default 4 bits > - control-parent: disable and enable interrupts on the parent interrupt > controller, needed for some broken implementations > +- clocks: Must contain a reference to the functional clock. The property is > + mandatory if the hardware implements a controllable functional clock for > + the irqpin controller instance. > + > + > +Example > +------- > + > + irqpin1: irqpin@e6900004 { The node name should be "interrupt-controller@e6900004". > + compatible = "renesas,intc-irqpin-r8a7740", > + "renesas,intc-irqpin"; > + #interrupt-cells = <2>; > + interrupt-controller; > + reg = <0xe6900004 4>, > + <0xe6900014 4>, > + <0xe6900024 1>, > + <0xe6900044 1>, > + <0xe6900064 1>; > + interrupts = <0 149 IRQ_TYPE_LEVEL_HIGH > + 0 149 IRQ_TYPE_LEVEL_HIGH > + 0 149 IRQ_TYPE_LEVEL_HIGH > + 0 149 IRQ_TYPE_LEVEL_HIGH > + 0 149 IRQ_TYPE_LEVEL_HIGH > + 0 149 IRQ_TYPE_LEVEL_HIGH > + 0 149 IRQ_TYPE_LEVEL_HIGH > + 0 149 IRQ_TYPE_LEVEL_HIGH>; Hm, 8 similar interrupts? > + clocks = <&mstp2_clks R8A7740_CLK_INTCA>; > + power-domains = <&pd_a4s>; > + }; WBR, Sergei