From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756594AbbCRSCg (ORCPT ); Wed, 18 Mar 2015 14:02:36 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:35522 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756551AbbCRSCd (ORCPT ); Wed, 18 Mar 2015 14:02:33 -0400 Message-ID: <5509BDB5.4090105@cogentembedded.com> Date: Wed, 18 Mar 2015 21:02:29 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: David Cohen CC: Heikki Krogerus , Felipe Balbi , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I Subject: Re: [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering References: <1426682433-133813-1-git-send-email-heikki.krogerus@linux.intel.com> <1426682433-133813-12-git-send-email-heikki.krogerus@linux.intel.com> <55098FD4.7080902@cogentembedded.com> <20150318165414.GA25477@psi-dev26.jf.intel.com> In-Reply-To: <20150318165414.GA25477@psi-dev26.jf.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/18/2015 07:54 PM, David Cohen wrote: >>> ULPI PHYs need to be bound to their controllers with a >>> lookup. This adds helpers that the ULPI drivers can use to >>> do both, the registration of the PHY and the lookup, at the >>> same time. >>> Signed-off-by: Heikki Krogerus >>> Cc: Kishon Vijay Abraham I >>> --- >>> drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++ >>> 1 file changed, 31 insertions(+) >>> create mode 100644 drivers/phy/ulpi_phy.h >>> diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h >>> new file mode 100644 >>> index 0000000..ac49fb6 >>> --- /dev/null >>> +++ b/drivers/phy/ulpi_phy.h >>> @@ -0,0 +1,31 @@ >>> +#include >>> + >>> +/** >>> + * Helper that registers PHY for a ULPI device and adds a lookup for binding it >>> + * and it's controller, which is always the parent. >>> + */ >>> +static inline struct phy >>> +*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops) >> Please either keep the prototype on a single line or don't break it like >> this. The result type should be all on the 1st line. > IMHO this is quite fine and readable. We can find this style in many > places of the kernel. It's the first time I'm seeing this particular "flavor". > Maybe it's a matter of taste :) Hopefully a good taste. :-) Some people also put the operator on the second line, when breaking up the expressions. Ew. :-) > BR, David >> [...] WBR, Sergei