[PATCH] Staging: lustre: file.c: fix coding style

[PATCH] Staging: lustre: file.c: fix coding style

[py]

Several warnings and errors of coding style rules corrected.
Compile tested.

Signed-off-by: Pierre-Yves Péneau <pierre-yves.peneau@gmx.com>
---
 drivers/staging/lustre/lustre/llite/file.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
index 6dab3ba..5c13b9a 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -270,7 +270,7 @@ static int ll_md_close(struct obd_export *md_exp, struct inode *inode,
 	int lockmode;
 	__u64 flags = LDLM_FL_BLOCK_GRANTED | LDLM_FL_TEST_LOCK;
 	struct lustre_handle lockh;
-	ldlm_policy_data_t policy = {.l_inodebits = {MDS_INODELOCK_OPEN}};
+	ldlm_policy_data_t policy = { .l_inodebits = {MDS_INODELOCK_OPEN} };
 	int rc = 0;
 
 	/* clear group lock, if present */
@@ -640,7 +640,8 @@ restart:
 			   result in a deadlock */
 			mutex_unlock(&lli->lli_och_mutex);
 			it->it_create_mode |= M_CHECK_STALE;
-			rc = ll_intent_file_open(file->f_path.dentry, NULL, 0, it);
+			rc = ll_intent_file_open(file->f_path.dentry,
+						NULL, 0, it);
 			it->it_create_mode &= ~M_CHECK_STALE;
 			if (rc)
 				goto out_openerr;
@@ -2682,7 +2683,7 @@ ll_file_flock(struct file *file, int cmd, struct file_lock *file_lock)
 	};
 	struct md_op_data *op_data;
 	struct lustre_handle lockh = {0};
-	ldlm_policy_data_t flock = {{0}};
+	ldlm_policy_data_t flock = { {0} };
 	__u64 flags = 0;
 	int rc;
 	int rc2 = 0;
-- 
1.7.9.5

Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style

[Patrick Farrell]

Perhaps this is just a formatting error in my email client, but 
shouldn't NULL be one more space over to line up with the '(' above?

On 03/18/2015 02:08 PM, py@amd48-systeme.lip6.fr wrote:
> +			rc = ll_intent_file_open(file->f_path.dentry,
> +						NULL, 0, it);

Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style

[Patrick Farrell]

Uck, my reply made the formatting even worse.  I'm trying to say it 
should look like this:
+            rc = ll_intent_file_open(file->f_path.dentry,
+                                                    NULL, 0, it);
Not like this:
+            rc = ll_intent_file_open(file->f_path.dentry,
+                                                   NULL, 0, it);

On 03/18/2015 02:31 PM, Patrick Farrell wrote:
> Perhaps this is just a formatting error in my email client, but 
> shouldn't NULL be one more space over to line up with the '(' above?
>
> On 03/18/2015 02:08 PM, py@amd48-systeme.lip6.fr wrote:
>> +            rc = ll_intent_file_open(file->f_path.dentry,
>> +                        NULL, 0, it);
>
> _______________________________________________
> HPDD-discuss mailing list
> HPDD-discuss@lists.01.org
> https://lists.01.org/mailman/listinfo/hpdd-discuss

Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style

[Julia Lawall]

On Wed, 18 Mar 2015, Patrick Farrell wrote:

> Uck, my reply made the formatting even worse.  I'm trying to say it should
> look like this:
> +            rc = ll_intent_file_open(file->f_path.dentry,
> +                                                    NULL, 0, it);
> Not like this:
> +            rc = ll_intent_file_open(file->f_path.dentry,
> +                                                   NULL, 0, it);

Both look wrong to me.  Are your tabs equivalent to 8 spaces?

julia

> 
> On 03/18/2015 02:31 PM, Patrick Farrell wrote:
> > Perhaps this is just a formatting error in my email client, but shouldn't
> > NULL be one more space over to line up with the '(' above?
> > 
> > On 03/18/2015 02:08 PM, py@amd48-systeme.lip6.fr wrote:
> > > +            rc = ll_intent_file_open(file->f_path.dentry,
> > > +                        NULL, 0, it);
> > 
> > _______________________________________________
> > HPDD-discuss mailing list
> > HPDD-discuss@lists.01.org
> > https://lists.01.org/mailman/listinfo/hpdd-discuss
> 
> 

Re: [PATCH] Staging: lustre: file.c: fix coding style

[Dan Carpenter]

Fix your email client From header to use your full name.

The subject is very vague.

On Wed, Mar 18, 2015 at 08:08:48PM +0100, py@amd48-systeme.lip6.fr wrote:
> Several warnings and errors of coding style rules corrected.

Which?

> Compile tested.

Put this under the --- cut off.

regards,
dan carpenter