From: Jens Axboe <axboe@kernel.dk>
To: Sam Bradshaw <sbradshaw@micron.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blkmq: Fix NULL pointer deref when all reserved tags in use
Date: Wed, 18 Mar 2015 15:51:08 -0600 [thread overview]
Message-ID: <5509F34C.3010404@kernel.dk> (raw)
In-Reply-To: <5509E8CB.8020404@micron.com>
On 03/18/2015 03:06 PM, Sam Bradshaw wrote:
>
>> Good catch! But why not put the hctx == NULL check in as a conditional
>> in bt_get() before running the queue? I can't imagine other cases where
>> calling blk_mq_run_hw_queue() with hctx == NULL would be a valid
>> scenario.
>
> The change was meant to be broad in scope. A runtime NULL deref is a
> rather unfortunate way to determine that there are other invalid scenarios.
Normally those kinds of issues would trigger quickly and it'd be
obvious. Granted, this was an error handling case for the special case
of reserved tags, so it persisted longer than it should have... But in
general, I would not be too worried.
> But given that both approaches fix the immediate problem, I'd be happy
> to change the patch as you suggest.
Thanks!
--
Jens Axboe
prev parent reply other threads:[~2015-03-18 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 20:36 [PATCH] blkmq: Fix NULL pointer deref when all reserved tags in use Sam Bradshaw
2015-03-18 20:40 ` Jens Axboe
2015-03-18 21:06 ` Sam Bradshaw
2015-03-18 21:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5509F34C.3010404@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).