From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757186AbbCRWIZ (ORCPT ); Wed, 18 Mar 2015 18:08:25 -0400 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:55754 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756060AbbCRWIX (ORCPT ); Wed, 18 Mar 2015 18:08:23 -0400 X-IronPort-AV: E=Sophos;i="5.11,425,1422950400"; d="scan'208";a="59799177" Message-ID: <5509F741.5010206@broadcom.com> Date: Wed, 18 Mar 2015 15:08:01 -0700 From: Scott Branden User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Stephen Warren CC: Rob Herring , Pawel Moll , "Mark Rutland" , Ian Campbell , Kumar Gala , "Florian Fainelli" , , , Lee Jones , Arnd Bergmann , Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Ralf Baechle , Greg Kroah-Hartman , , , Subject: Re: [PATCH] dt-bindings: brcm: rationalize Broadcom documentation naming References: <1426706645-19313-1-git-send-email-sbranden@broadcom.com> <5509D528.1080208@wwwdotorg.org> <5509F3CC.1010207@broadcom.com> <5509F61E.5000702@wwwdotorg.org> In-Reply-To: <5509F61E.5000702@wwwdotorg.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-03-18 03:03 PM, Stephen Warren wrote: > On 03/18/2015 03:53 PM, Scott Branden wrote: >> Hi Stephen, >> >> On 15-03-18 12:42 PM, Stephen Warren wrote: >>> On 03/18/2015 01:24 PM, Scott Branden wrote: >>>> This patchset attempts to standarize the naming of dt-bindings >>>> documents based on the Broadcom vendor prefix of brcm. >>>> >>>> Although there are no guidelines currently present for how to name >>>> the dt-bindings document the "vendor,binding.txt" style is in use by >>>> some of the other vendors. >>> >>> Conceptually I'm fine with this. >>> Acked-by: Stephen Warren >>> >>> The only comment I have is that some bindings refer to other bindings, >>> e.g. an I2C controller binding might refer to the core I2C binding to >>> define core I2C properties. Since this patch moves a couple files >>> between directories, did you double-check that none of the pathnames in >>> those references need fixing up? >> >> Yes, I read all the brcm documents and did not find references to the >> moved files. > > Oh, I meant references *from* the moved files to other files. Yes, some of the moved/renamed files reference other files. But those are to references to common dt-binding documentation files and of the form Documentation/devicetree/bindings/xxx/yyy.txt > > BTW, I just noticed that both your patches don't have signed-off-by lines. Whoops - thanks - will have to correct. Plus, add your Acked-by.