From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755469AbbCRX4h (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 19:56:37 -0400
Received: from mail-ig0-f173.google.com ([209.85.213.173]:35803 "EHLO
	mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752021AbbCRX4f (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 19:56:35 -0400
Message-ID: <550A10B1.9080701@gmail.com>
Date: Wed, 18 Mar 2015 17:56:33 -0600
From: David Ahern <dsahern@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Don Zickus <dzickus@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: perf: thread is its own parent
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Don:

In this commit:

commit 363b785f3805a2632eb09a8b430842461c21a640
Author: Don Zickus <dzickus@redhat.com>
Date:   Fri Mar 14 10:43:44 2014 -0400

     perf tools: Speed up thread map generation

you made a thread its own parent when synthesizing fork events:

static int perf_event__synthesize_fork(struct perf_tool *tool,
                                        union perf_event *event, pid_t pid,
                                        pid_t tgid, 
perf_event__handler_t process,
                                        struct machine *machine)
{
         memset(&event->fork, 0, sizeof(event->fork) + 
machine->id_hdr_size);

         event->fork.ppid = tgid;
         event->fork.ptid = tgid;
         event->fork.pid  = tgid;
         event->fork.tid  = pid;
         event->fork.header.type = PERF_RECORD_FORK;


Any particular reason or just an oversight?

David