From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752045AbbCSCeW (ORCPT ); Wed, 18 Mar 2015 22:34:22 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:12516 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbbCSCeU (ORCPT ); Wed, 18 Mar 2015 22:34:20 -0400 X-AuditID: cbfee68d-f79296d000004278-cc-550a359610d6 Message-id: <550A3595.6090009@samsung.com> Date: Thu, 19 Mar 2015 11:33:57 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Robert Baldyga Cc: balbi@ti.com, gregkh@linuxfoundation.org, myungjoo.ham@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com Subject: Re: [RFC 00/19] dwc3: add USB OTG role switch support References: <1426687464-2563-1-git-send-email-r.baldyga@samsung.com> In-reply-to: <1426687464-2563-1-git-send-email-r.baldyga@samsung.com> Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsWyRsSkRHeaKVeowd+HwhYH79dbNC9ez2Zx edccNotFy1qZLdYeuctucbtxBZvFg8M72R3YPfbPXcPu0bdlFaPH8RvbmTw+b5ILYInisklJ zcksSy3St0vgymh6upe1YKJCxfqzaQ2M78W7GDk5JARMJDpeN7JC2GISF+6tZ+ti5OIQEljK KPHu6Hk2mKKLry6wQCQWMUqcOdbOCuG8ZpRYPfMtYxcjBwevgJbEui9cIA0sAqoSG/7dZgKx 2YDC+1/cABskKhAmsXL6FRYQm1dAUOLH5HtgtghQzZ2P89lBZjILzGWUWLthGVizsICdRMPp hcwg84UEXCT6PviBhDkFXCV+NExmBLGZBdQlJs1bxAxhy0tsXvOWGWSOhMApdokXLc+ZIA4S kPg2+RALyBwJAVmJTQeYIR6TlDi44gbLBEaxWUhOmoVk7CwkYxcwMq9iFE0tSC4oTkovMtQr TswtLs1L10vOz93ECIy00/+e9e5gvH3A+hCjAAejEg+vxFWOUCHWxLLiytxDjKZAV0xklhJN zgfGc15JvKGxmZGFqYmpsZG5pZmSOK+i1M9gIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYwt fpzczZfqixawpi7TyDBdc6NoIq+fQ3QM15KwZnfB/QGmYsErZmp3/fA9kJm7WzlhsvBBMe6K sC3cc33/Wxdct9i1/dNZC7kD13hiIiT0M6UEdJ+WhR76t36Ou+CmgCCNaN4src2r14steMM3 0/H2n2P3vsy8VNpd9SN/H0+zSqG+o9ehXCWW4oxEQy3mouJEAIu5rKCvAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsVy+t9jAd1pplyhBq8W8VgcvF9v0bx4PZvF 5V1z2CwWLWtltlh75C67xe3GFWwWDw7vZHdg99g/dw27R9+WVYwex29sZ/L4vEkugCWqgdEm IzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+gCJYWyxJxS oFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWNG09O9rAUTFSrWn01rYHwv3sXIySEh YCJx8dUFFghbTOLCvfVsXYxcHEICixglzhxrZ4VwXjNKrJ75lrGLkYODV0BLYt0XLpAGFgFV iQ3/bjOB2GxA4f0vbrCB2KICYRIrp18BG8orICjxY/I9MFsEqObOx/nsIDOZBeYySqzdsAys WVjATqLh9EJmkPlCAi4SfR/8QMKcAq4SPxomM4LYzALqEpPmLWKGsOUlNq95yzyBUWAWkhWz kJTNQlK2gJF5FaNoakFyQXFSeq6RXnFibnFpXrpecn7uJkZwHD+T3sG4qsHiEKMAB6MSD6/E VY5QIdbEsuLK3EOMEhzMSiK8ZSc4Q4V4UxIrq1KL8uOLSnNSiw8xmgJDYCKzlGhyPjDF5JXE GxqbmBlZGpkbWhgZmyuJ8yrZt4UICaQnlqRmp6YWpBbB9DFxcEo1MNoqblnJOO3z+Yny1nl8 7kGFpb8Vbp2ud6gv7JUw4730bqP+brvH5xxntM/eNOPqNKM7DJcORd9l7/y9K1j6ZWd80HnB mHtesawbFj3f49F9JGqz5Mp5N5gXrLMo4XjHtPhmOZOt7R3dvf/8gtQ5i35/vq3GZnLhausc sfzD3O7fYkt8E6UWeyqxFGckGmoxFxUnAgDB4NjL+QIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, Did you test the extcon-odroid-otg driver on Odroid-U3? Thanks, Chanwoo Choi On 03/18/2015 11:04 PM, Robert Baldyga wrote: > Hello, > > This patchset introduces OTG feature in DWC3 DRD driver. This allows > to change dynamically between host and peripheral mode depending on > detected USB cable type. > > DWC3 driver behaviour is changed only in situation when selected operation > mode (dr_mode) is "otg", and hardware OTG support is available or extended > OTG operations are supplied for given platform. > > It such conditions are fulfilled, none of modes is enabled by default > and dwc3 core Best regards, > Robert Baldygais being uninitialized. After USB cable detection relevant > mode is selected and dwc3 core is initialized. Cable disconnection causes > deinitialization of dwc3 core. > > File otg.c is inspired by code of DWC3 driver from Hardkernel linux > sources [1]. I have never tested it on DWC3 version equipped with hardware > OTG support, but I belive that this code have chance to work or at least > it's easy to fix. I have tested this on OdroidXU3 board which has USB > cable detection mechanism based on two gpio pins. I used extcon driver > for those feature, which is also attached to following patchset. > > I consider if ext_otg_ops it the right solution. Current solution is > based on Hardkernel sources, but it's very likely that adding extcon > support directly to otg.c would be generic enough, as most of cable > detection mechanisms can be simply represented by extcon devices. > > Thanks in advance for your comments. > > Best regards, > Robert Baldyga > > [1] https://github.com/hardkernel/linux > > Robert Baldyga (19): > extcon: add extcon-odroid-usbotg driver > dt-bindings: extcon: Add doc for extcon-odroid-usbotg > ARM: dts: exynos5422-odroidxu3: add odroid-usbotg extcon support > dwc3: gadget: add VBUS session handling > dwc3: gadget: enable/disable ep0 in dwc3_gadget_run_stop() > dwc3: gadget: check returned value in suspend/resume > dwc3: core: cleanup suspend/resume code > dwc3: core: handle event buffers in core_init/exit > dwc3: core: make dwc3_core_init/exit non-static > dwc3: add missing OTG register definitions > dwc3: add OTG handling code > dwc3: otg: add ext_otg_ops support > dwc3: gadget: register gadget in OTG core > dwc3: host: don't add XHCI device only if in OTG mode > dwc3: core: initialize OTG in DWC3 core > dwc3: exynos: add software role switching code > ARM: dts: exynos5420: set usb3_lpm_capable in dwc3 controllers > ARM: dts: exynos5420: add snps,dis_u3_susphy_quirk to dwc3 controllers > ARM: dts: exynos5422-odroidxu3: make usbdrd3 extcon client > > .../bindings/extcon/extcon-odroid-usbotg.txt | 16 + > .../devicetree/bindings/usb/exynos-usb.txt | 4 + > arch/arm/boot/dts/exynos5420.dtsi | 6 + > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 24 + > drivers/extcon/Kconfig | 4 + > drivers/extcon/Makefile | 1 + > drivers/extcon/extcon-odroid-usbotg.c | 257 +++++++++ > drivers/usb/dwc3/Kconfig | 1 + > drivers/usb/dwc3/Makefile | 4 + > drivers/usb/dwc3/core.c | 66 ++- > drivers/usb/dwc3/core.h | 22 + > drivers/usb/dwc3/dwc3-exynos.c | 162 ++++++ > drivers/usb/dwc3/gadget.c | 106 ++-- > drivers/usb/dwc3/host.c | 10 +- > drivers/usb/dwc3/otg.c | 577 +++++++++++++++++++++ > drivers/usb/dwc3/otg.h | 113 ++++ > 16 files changed, 1320 insertions(+), 53 deletions(-) > create mode 100644 Documentation/devicetree/bindings/extcon/extcon-odroid-usbotg.txt > create mode 100644 drivers/extcon/extcon-odroid-usbotg.c > create mode 100644 drivers/usb/dwc3/otg.c > create mode 100644 drivers/usb/dwc3/otg.h >