From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbbCSGXx (ORCPT ); Thu, 19 Mar 2015 02:23:53 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:32895 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbbCSGXw (ORCPT ); Thu, 19 Mar 2015 02:23:52 -0400 Message-ID: <550A6B54.7080505@huawei.com> Date: Thu, 19 Mar 2015 14:23:16 +0800 From: Wang Nan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Ingo Molnar , Ingo Molnar CC: Namhyung Kim , , , , Subject: Re: [PATCH v3 -tip] perf tools: fix building error for arm64. References: <20150317131259.GC31698@krava.brq.redhat.com> <1426598987-75245-1-git-send-email-wangnan0@huawei.com> <20150318071935.GT943@sejong> In-Reply-To: <20150318071935.GT943@sejong> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.69.129] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.550A6B76.012B,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 383b53117253a0e2b75f52666841b630 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ingo, Could you please pick this patch for -tip tree? It fixes a bug which makes arm64 -tip building failure. Thank you. On 2015/3/18 15:19, Namhyung Kim wrote: > On Tue, Mar 17, 2015 at 01:29:47PM +0000, Wang Nan wrote: >> Commit b11db6581beaccef8ae9a388ae96074aa5cc144f ("perf tools: Fix build >> error on ARCH=i386/x86_64/sparc64") uses sed on ARCH, which triggers a >> bug in sequence of sed expression, where 's/arm.*/arm/' will replace >> 'arm64' to 'arm', causes arm64 building failure. >> >> This patch prevent 'arm64' to be mached for 'arm.*' case. >> >> Signed-off-by: Wang Nan > > Acked-by: Namhyung Kim > > Thanks, > Namhyung > > >> --- >> v2 -> v3: >> Make the 'arm.*' expression complete according to Jiri Olsa's suggestion. >> --- >> tools/perf/config/Makefile.arch | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/perf/config/Makefile.arch b/tools/perf/config/Makefile.arch >> index e972057..e11fbd6 100644 >> --- a/tools/perf/config/Makefile.arch >> +++ b/tools/perf/config/Makefile.arch >> @@ -4,7 +4,7 @@ endif >> >> ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/ \ >> -e s/sun4u/sparc/ -e s/sparc64/sparc/ \ >> - -e s/arm.*/arm/ -e s/sa110/arm/ \ >> + -e /arm64/!s/arm.*/arm/ -e s/sa110/arm/ \ >> -e s/s390x/s390/ -e s/parisc64/parisc/ \ >> -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \ >> -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \ >> -- >> 1.8.3.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/