From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbbCSHXC (ORCPT ); Thu, 19 Mar 2015 03:23:02 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:35278 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbbCSHXA (ORCPT ); Thu, 19 Mar 2015 03:23:00 -0400 Message-ID: <550A794C.7020904@gmail.com> Date: Thu, 19 Mar 2015 09:22:52 +0200 From: Alex Dowad User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman , linux-kernel@vger.kernel.org CC: Michael Neuling , Paul Gortmaker , Paul Mackerras , Anton Blanchard , Vineeth Vijayan , Christoph Lameter , "open list:LINUX FOR POWERPC..." Subject: Re: [23/32] powerpc: copy_thread(): rename 'arg' argument to 'kthread_arg' References: <20150319064519.6BEA814010F@ozlabs.org> In-Reply-To: <20150319064519.6BEA814010F@ozlabs.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/03/15 08:45, Michael Ellerman wrote: > On Fri, 2015-13-03 at 18:14:46 UTC, Alex Dowad wrote: >> The 'arg' argument to copy_thread() is only ever used when forking a new >> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency >> with do_fork() and other arch-specific implementations of copy_thread()). > > I don't understand the bit about consistency with do_fork() ? This series of patches includes one patch which renames the arg for do_fork(), and others which rename the same arg for each arch-specific implementation of copy_thread(). So if all of them are accepted and merged, then all will be consistent. If only some of the patches are accepted, I will rewrite the commit message so it doesn't mention "consistency". Thanks! AD > > Otherwise it looks fine. > > cheers