From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbbCSOlL (ORCPT ); Thu, 19 Mar 2015 10:41:11 -0400 Received: from mail-by2on0135.outbound.protection.outlook.com ([207.46.100.135]:54254 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752000AbbCSOlI (ORCPT ); Thu, 19 Mar 2015 10:41:08 -0400 X-WSS-ID: 0NLGRGD-07-MD9-02 X-M-MSG: Message-ID: <550ADFFD.2090708@amd.com> Date: Thu, 19 Mar 2015 09:41:01 -0500 From: Aravind Gopalakrishnan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Borislav Petkov , "Luck, Tony" CC: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "slaoub@gmail.com" , "luto@amacapital.net" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH] x86, mce, severities: Add AMD severities function References: <1426526164-3806-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <20150317102048.GG19645@pd.tnic> <5508756A.1090908@amd.com> <20150317184441.GI19645@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F32A234ED@ORSMSX114.amr.corp.intel.com> <20150319092953.GB10860@pd.tnic> In-Reply-To: <20150319092953.GB10860@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Aravind.Gopalakrishnan@amd.com; alien8.de; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(979002)(6009001)(428002)(377454003)(479174004)(164054003)(199003)(189002)(24454002)(51704005)(93886004)(86362001)(87936001)(92566002)(106466001)(105586002)(80316001)(120886001)(77156002)(62966003)(23676002)(65806001)(65956001)(64126003)(59896002)(47776003)(50466002)(2950100001)(33656002)(87266999)(77096005)(54356999)(65816999)(50986999)(46102003)(101416001)(76176999)(36756003)(83506001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR02MB1228;H:atltwp01.amd.com;FPR:;SPF:None;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR02MB1228; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:BY1PR02MB1228;BCL:0;PCL:0;RULEID:;SRVR:BY1PR02MB1228; X-Forefront-PRVS: 052017CAF1 X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2015 14:41:04.9840 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR02MB1228 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/19/2015 4:29 AM, Borislav Petkov wrote: > On Thu, Mar 19, 2015 at 12:01:32AM +0000, Luck, Tony wrote: >> One other thought. Instead of the run-time test to see if this is an AMD processor on every call >> to this function, would it be cleaner to: >> >> 1) Rename existing mce_severity() function to mce_severity_intel() >> 2) Declare a function pointer named mce_severity. >> 3) Assign that pointer to the _intel() or _amd() function in mce_init() > Yes, of course. We do that (or at least pretty close) in other paths > too. > > Ok, I'll work on this and prepend the changes to the current version of the patch. Would you prefer the changes be in a separate patch or lump it in along with current version? Thanks, -Aravind.