Re: [PATCH 1/2] xen: prepare p2m list for memory hotplug

Paul Bolle
2015-03-19T19:15:11Z

On Thu, 2015-03-19 at 15:31 +0100, Juergen Gross wrote:
> --- a/arch/x86/xen/p2m.c
> +++ b/arch/x86/xen/p2m.c

> +#ifdef CONFIG_X86_32
> +BUILD_BUG_ON_MSG(CONFIG_XEN_BALLOON_MEMORY_HOTPLUG_LIMIT > 64)
> +#endif

I assume BUILD_BUG_ON_MSG() aborts the build.

> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig

> +config XEN_BALLOON_MEMORY_HOTPLUG_LIMIT
> + int
> + default 512 if X86_64
> + default 4 if X86_32
> + depends on XEN_HAVE_PVMMU
> + depends on XEN_BALLOON_MEMORY_HOTPLUG
> + help
> + Upper limit in GBs a pv domain can be expanded to using memory
> + hotplug.
> +
> + This value is used to allocate enough space in internal tables needed
> + for physical memory administration.
> +

I think adding a
range 1 64 if X86_32

would allow to drop the BUILD_BUG_ON_MSG(). (I haven't tested this so
you're allowed to bark at me if this ends up wasting your time.)

Paul Bolle