From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756168AbbCSRiY (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Mar 2015 13:38:24 -0400
Received: from service87.mimecast.com ([91.220.42.44]:44444 "EHLO
	service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752345AbbCSRiV convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Mar 2015 13:38:21 -0400
Message-ID: <550B09A1.4020801@arm.com>
Date: Thu, 19 Mar 2015 17:38:41 +0000
From: Sudeep Holla <sudeep.holla@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Mark Rutland <mark.rutland@arm.com>,
        Suzuki Poulose <Suzuki.Poulose@arm.com>
CC: Sudeep Holla <sudeep.holla@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Nicolas Pitre <nico@linaro.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Kukjin Kim <kgene@kernel.org>,
        Abhilash Kesavan <a.kesavan@samsung.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
        Olof Johansson <olof@lixom.net>, Pawel Moll <Pawel.Moll@arm.com>,
        Punit Agrawal <Punit.Agrawal@arm.com>,
        Will Deacon <Will.Deacon@arm.com>,
        Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions
 for PMU driver
References: <1426000735-14375-4-git-send-email-suzuki.poulose@arm.com> <1426585901-19137-1-git-send-email-suzuki.poulose@arm.com> <20150319173252.GC10153@leverpostej>
In-Reply-To: <20150319173252.GC10153@leverpostej>
X-OriginalArrivalTime: 19 Mar 2015 17:38:18.0869 (UTC) FILETIME=[7CCEBA50:01D0626B]
X-MC-Unique: 115031917381902101
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 19/03/15 17:32, Mark Rutland wrote:
> One more thing:
>
>> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
>>   							pdev->dev.of_node);
>>   	if (!match)
>>   		return NULL;
>> +	if (match->data)
>> +		return match->data;
>>
>> +	dev_warn(&pdev->dev, "DEPRECATED compatible property,"
>> +			 "requires secure access to CCI registers");
>>   	return probe_cci_model(pdev);
>>   }
>
> Before the probe, could we please have:
>
> 	if (!IS_ENABLED(CONFIG_ARM))
> 		return -EINVAL;
>
> On arm64 we require a model-specific string, and we shouldn't go
> touching secure-only registers.
>

IIUC platform_has_secure_cci_access always return false for ARM64
preventing any secure access. No ?

Regards,
Sudeep