Re: [PATCH 2/2] uio: Fix uio driver to refcount device

Brian Russell
2015-03-20T14:55:36Z

On 20/03/15 12:18, Greg Kroah-Hartman wrote:
> On Thu, Mar 19, 2015 at 05:55:28PM +0000, Brian Russell wrote:
>> Protect uio driver from its owner being unplugged while there are open fds.
>> Embed struct device in struct uio_device, use refcounting on device, free
>> uio_device on release.
>> info struct passed in uio_register_device can be freed on unregister, so null
>> out the field in uio_unregister_device and check accesses.
>>
>> Signed-off-by: Brian Russell <brussell@brocade.com>
>> ---
>> drivers/uio/uio.c | 58 +++++++++++++++++++++++++++++++---------------
>> include/linux/uio_driver.h | 2 +-
>> 2 files changed, 40 insertions(+), 20 deletions(-)
>
> This patch is line-wrapped and can not be applied :(
>
> Please fix up your email client and resend. I've applied the first
> patch, which worked just fine, no need to resend it.
>

Sorry about that, I've resent. Thanks for the review.

Brian

> thanks,
>
> greg k-h
>