From: Chris Metcalf <cmetcalf@ezchip.com>
To: Alex Dowad <alexinbeijing@gmail.com>, <linux-kernel@vger.kernel.org>
Cc: Christoph Lameter <cl@linux.com>, Joe Perches <joe@perches.com>,
Tejun Heo <tj@kernel.org>, james hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH 28/32] tile: copy_thread(): rename 'arg' argument to 'kthread_arg'
Date: Thu, 19 Mar 2015 14:06:51 -0400 [thread overview]
Message-ID: <550B103B.801@ezchip.com> (raw)
In-Reply-To: <55074093.40809@gmail.com>
On 03/16/2015 04:44 PM, Alex Dowad wrote:
>
> On 16/03/15 22:19, Chris Metcalf wrote:
>> On 3/13/2015 2:14 PM, Alex Dowad wrote:
>>> The 'arg' argument to copy_thread() is only ever used when forking a
>>> new
>>> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and
>>> consistency
>>> with do_fork() and other arch-specific implementations of
>>> copy_thread()).
>>>
>>> Signed-off-by: Alex Dowad<alexinbeijing@gmail.com>
>>> ---
>>> arch/tile/kernel/process.c | 11 +++++++----
>>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> Acked-by: Chris Metcalf <cmetcalf@ezchip.com>
>>
>> If you would prefer me to take this into the tile tree, let me know,
>> and I am happy to do so.
>>
> Hi Chris,
>
> Thanks for your kind offer. I am a 100% genuine true-blue kernel
> newbie and have no idea whether a change like this should be merged
> individually by each arch maintainer, or all together at some point
> upstream (or is it downstream? I'm not sure about my streams). Do you
> have any suggestion?
>
> Thank you again! AD
I think James Hogan's replies were on-target [1]. My sense is that
since it's a cleanup, and since you're trying for consistency, if you
can gather up a few Acked-by's from maintainers, it probably makes sense
to have it taken as a series.
[1] https://lkml.org/lkml/2015/3/16/477
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
next prev parent reply other threads:[~2015-03-19 18:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 18:14 [PATCH 11/32] frv: copy_thread(): rename 'arg' argument to 'kthread_arg' Alex Dowad
2015-03-13 18:14 ` [PATCH 12/32] hexagon: " Alex Dowad
2015-03-16 16:25 ` rkuo
2015-03-13 18:14 ` [PATCH 13/32] ia64: copy_thread(): rename 'user_stack_size' " Alex Dowad
2015-03-14 17:54 ` Alex Dowad
2015-03-13 18:14 ` [PATCH 14/32] m32r: copy_thread(): rename 'arg' " Alex Dowad
2015-03-13 18:14 ` [PATCH 15/32] m68k: " Alex Dowad
2015-03-13 18:14 ` [PATCH 16/32] metag: " Alex Dowad
2015-03-16 11:39 ` James Hogan
2015-03-16 13:13 ` [PATCHv2 " Alex Dowad
2015-03-16 14:31 ` James Hogan
2015-03-16 14:38 ` Alex Dowad
2015-03-16 14:38 ` [PATCHv3 " Alex Dowad
2015-03-16 14:52 ` James Hogan
2015-03-13 18:14 ` [PATCH 17/32] microblaze: " Alex Dowad
2015-03-13 18:14 ` [PATCH 18/32] mips: " Alex Dowad
2015-03-13 18:14 ` [PATCH 19/32] mn10300: copy_thread(): rename 'ustk_size' " Alex Dowad
2015-03-13 18:14 ` [PATCH 20/32] nios2: copy_thread(): rename 'arg' " Alex Dowad
2015-03-13 18:14 ` [PATCH 21/32] openrisc: " Alex Dowad
2015-03-13 18:14 ` [PATCH 22/32] parisc: " Alex Dowad
2015-03-13 18:14 ` [PATCH 23/32] powerpc: " Alex Dowad
2015-03-19 6:45 ` [23/32] " Michael Ellerman
2015-03-19 7:22 ` Alex Dowad
2015-03-19 23:54 ` Michael Ellerman
2015-03-24 19:49 ` Alex Dowad
2015-03-25 1:35 ` Michael Ellerman
2015-03-13 18:14 ` [PATCH 24/32] s390: " Alex Dowad
2015-03-13 18:14 ` [PATCH 25/32] score: " Alex Dowad
2015-03-13 18:14 ` [PATCH 26/32] sh: " Alex Dowad
2015-03-13 18:14 ` [PATCH 27/32] sparc: " Alex Dowad
2015-03-13 18:14 ` [PATCH 28/32] tile: " Alex Dowad
2015-03-16 20:19 ` Chris Metcalf
2015-03-16 20:44 ` Alex Dowad
2015-03-19 18:06 ` Chris Metcalf [this message]
2015-03-13 18:14 ` [PATCH 29/32] um: " Alex Dowad
2015-03-13 18:14 ` [PATCH 30/32] unicore32: copy_thread(): rename 'stk_sz' " Alex Dowad
2015-03-13 18:14 ` [PATCH 31/32] x86: copy_thread(): rename 'arg' " Alex Dowad
2015-03-13 18:14 ` [PATCH 32/32] xtensa: " Alex Dowad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B103B.801@ezchip.com \
--to=cmetcalf@ezchip.com \
--cc=alexinbeijing@gmail.com \
--cc=cl@linux.com \
--cc=james.hogan@imgtec.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).