From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757175AbbCSSHF (ORCPT ); Thu, 19 Mar 2015 14:07:05 -0400 Received: from mail-am1on0087.outbound.protection.outlook.com ([157.56.112.87]:16208 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757132AbbCSSHD (ORCPT ); Thu, 19 Mar 2015 14:07:03 -0400 Message-ID: <550B103B.801@ezchip.com> Date: Thu, 19 Mar 2015 14:06:51 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Alex Dowad , CC: Christoph Lameter , Joe Perches , Tejun Heo , james hogan Subject: Re: [PATCH 28/32] tile: copy_thread(): rename 'arg' argument to 'kthread_arg' References: <1426270496-26362-1-git-send-email-alexinbeijing@gmail.com> <1426270496-26362-18-git-send-email-alexinbeijing@gmail.com> <55073AD4.8030506@ezchip.com> <55074093.40809@gmail.com> In-Reply-To: <55074093.40809@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BN1PR12CA0004.namprd12.prod.outlook.com (25.160.77.14) To AM3PR02MB0536.eurprd02.prod.outlook.com (25.160.6.142) Authentication-Results: imgtec.com; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB0536; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10009020)(6049001)(6009001)(24454002)(377454003)(479174004)(51704005)(50466002)(42186005)(40100003)(122386002)(66066001)(65956001)(47776003)(65806001)(33656002)(65816999)(36756003)(64126003)(76176999)(54356999)(50986999)(23746002)(87976001)(86362001)(83506001)(19580395003)(19580405001)(2950100001)(62966003)(77156002)(15975445007)(93886004)(77096005)(46102003)(92566002)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR02MB0536;H:[10.7.0.41];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:AM3PR02MB0536;BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB0536; X-Forefront-PRVS: 052017CAF1 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2015 18:07:00.3320 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR02MB0536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/16/2015 04:44 PM, Alex Dowad wrote: > > On 16/03/15 22:19, Chris Metcalf wrote: >> On 3/13/2015 2:14 PM, Alex Dowad wrote: >>> The 'arg' argument to copy_thread() is only ever used when forking a >>> new >>> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and >>> consistency >>> with do_fork() and other arch-specific implementations of >>> copy_thread()). >>> >>> Signed-off-by: Alex Dowad >>> --- >>> arch/tile/kernel/process.c | 11 +++++++---- >>> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> Acked-by: Chris Metcalf >> >> If you would prefer me to take this into the tile tree, let me know, >> and I am happy to do so. >> > Hi Chris, > > Thanks for your kind offer. I am a 100% genuine true-blue kernel > newbie and have no idea whether a change like this should be merged > individually by each arch maintainer, or all together at some point > upstream (or is it downstream? I'm not sure about my streams). Do you > have any suggestion? > > Thank you again! AD I think James Hogan's replies were on-target [1]. My sense is that since it's a cleanup, and since you're trying for consistency, if you can gather up a few Acked-by's from maintainers, it probably makes sense to have it taken as a series. [1] https://lkml.org/lkml/2015/3/16/477 -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com