From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbbCSV15 (ORCPT ); Thu, 19 Mar 2015 17:27:57 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:38128 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751069AbbCSV1y (ORCPT ); Thu, 19 Mar 2015 17:27:54 -0400 Message-ID: <550B3F58.90109@kernel.dk> Date: Thu, 19 Mar 2015 15:27:52 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Tejun Heo , Jeff Moyer CC: kent.overstreet@gmail.com, Benjamin LaHaise , linux-kernel@vger.kernel.org Subject: Re: serial percpu_ref draining in exit_aio() References: <20150319173413.GU25365@htj.duckdns.org> <550B30D5.9080207@kernel.dk> <20150319210051.GE19657@htj.duckdns.org> In-Reply-To: <20150319210051.GE19657@htj.duckdns.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/19/2015 03:00 PM, Tejun Heo wrote: > On Thu, Mar 19, 2015 at 04:58:33PM -0400, Jeff Moyer wrote: >> Do you really want to do memory allocation in the exit path? That >> sounds like a bad idea to me. (Of course, now you're going to point out >> all the places that currently happens, right? ;-) > > I think we just need a counter there - let everyone count down as they > exit and the last one trigger the completion, no? Yeah that's a good point, that'd be cleaner too. I'll change it and test that. -- Jens Axboe