From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751219AbbCTGMJ (ORCPT ); Fri, 20 Mar 2015 02:12:09 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48981 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbbCTGMI (ORCPT ); Fri, 20 Mar 2015 02:12:08 -0400 Message-ID: <550BBA32.8060308@codeaurora.org> Date: Fri, 20 Mar 2015 11:42:02 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Stephen Boyd CC: mturquette@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: qcom: fix RCG M/N counter configuration References: <1425462575-11486-1-git-send-email-architt@codeaurora.org> <20150320052807.GA11451@codeaurora.org> In-Reply-To: <20150320052807.GA11451@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2015 10:58 AM, Stephen Boyd wrote: > On 03/04, Archit Taneja wrote: >> Currently, a RCG's M/N counter (used for fraction division) is set to either >> 'bypass' (counter disabled) or 'dual edge' (counter enabled) based on whether >> the corresponding rcg struct has a mnd field specified and a non-zero N. >> >> In the case where M and N are the same value, the M/N counter is still enabled >> by code even though no division takes place. Leaving the RCG in such a state >> can result in improper behavior. This was observed with the DSI pixel clock RCG >> when M and N were both set to 1. >> >> Add an additional check (M != N) to enable the M/N counter only when it's needed >> for fraction division. >> >> Signed-off-by: Archit Taneja >> --- > > I'm going to queue this up for 4.1 given that this isn't a new > regression. But I'll tag it for stable so that we get it into all > the stable trees. Great, that sounds good. Thanks, Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project