Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK

[Vladimir Murzin <vladimir.murzin@arm.com>]

On 20/03/15 10:23, Paul Bolle wrote:
> On Fri, 2015-03-13 at 02:03 -0700, Guenter Roeck wrote:
>> Building alpha:allmodconfig fails with
>>
>> mm/memtest.c: In function 'reserve_bad_mem':
>> mm/memtest.c:38:2: error: implicit declaration of function 'memblock_reserve'
>> mm/memtest.c: In function 'do_one_pass':
>> mm/memtest.c:77:2: error: implicit declaration of function 'for_each_free_mem_range'
>> mm/memtest.c:77:73: error: expected ';' before '{' token
>>
>> because it depends on MEMBLOCK which is not defined for the alpha
>> architecture.
>>
>> Fixes: 420c89e6185d ("mm: move memtest under mm")
>> Cc: Vladimir Murzin <vladimir.murzin@arm.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>  lib/Kconfig.debug | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 8b4e69a..dc1e69c 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -1797,6 +1797,7 @@ config TEST_UDELAY
>>  
>>  config MEMTEST
>>  	bool "Memtest"
>> +	depends on MEMBLOCK
>>  	---help---
>>  	  This option adds a kernel parameter 'memtest', which allows memtest
>>  	  to be set.
> 
> (There's now a bot checking this stuff, but I couldn't resist reporting
> it when my script spotted it.)
> 
> Please do
>     $ git grep -n "config\s\+MEMBLOCK\b" next-20150320
>     $ git grep -n "config\s\+MEMBLOCK\b" v4.0-rc4
> 
> I think this patch simply disables MEMTEST altogether. I'm guessing this

I should have tested it before... yes, you (and bot) are right, after
patch applied memtest is not available at arm/arm64 which definitely has
memblock.

> should have added
> 	depends on HAVE_MEMBLOCK
> 

Could we fold this change or separate patch is needed?

Cheers
Vladimir

> 
> Paul Bolle
> 
>