From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751397AbbCTMGM (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Mar 2015 08:06:12 -0400
Received: from mail-pd0-f178.google.com ([209.85.192.178]:33801 "EHLO
	mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750823AbbCTMGJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Mar 2015 08:06:09 -0400
Message-ID: <550C0D1C.1070200@gmail.com>
Date: Fri, 20 Mar 2015 17:35:48 +0530
From: Varka Bhadram <varkabhadram@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Lad Prabhakar <prabhakar.csengg@gmail.com>,
        LMML <linux-media@vger.kernel.org>, devicetree@vger.kernel.org,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor
References: <1426852133-14539-1-git-send-email-prabhakar.csengg@gmail.com>
In-Reply-To: <1426852133-14539-1-git-send-email-prabhakar.csengg@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/20/2015 05:18 PM, Lad Prabhakar wrote:

> From: Benoit Parrot <bparrot@ti.com>
>
> this patch adds support for omnivision's ov2659
> sensor, the driver supports following features:
> 1: Asynchronous probing
> 2: DT support
> 3: Media controller support
>
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>   Changes for v8:
>   --------------
>   a. Now setting the link_frequency control in set_fmt
>      callback instead of implementing g_volatile_ctrl()
>      for it and setting it there.
>
>   v7: https://patchwork.kernel.org/patch/6034651/
>   v6: https://patchwork.kernel.org/patch/6012751/
>   v5: https://patchwork.kernel.org/patch/6000161/
>   v4: https://patchwork.kernel.org/patch/5961661/
>   v3: https://patchwork.kernel.org/patch/5959401/
>   v2: https://patchwork.kernel.org/patch/5859801/
>   v1: https://patchwork.linuxtv.org/patch/27919/
>
>   .../devicetree/bindings/media/i2c/ov2659.txt       |   38 +
>   MAINTAINERS                                        |   10 +
>   drivers/media/i2c/Kconfig                          |   11 +
>   drivers/media/i2c/Makefile                         |    1 +
>   drivers/media/i2c/ov2659.c                         | 1528 ++++++++++++++++++++
>   include/media/ov2659.h                             |   33 +
>   6 files changed, 1621 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2659.txt
>   create mode 100644 drivers/media/i2c/ov2659.c
>   create mode 100644 include/media/ov2659.h
>
(...)

> +static struct ov2659_platform_data *
> +ov2659_get_pdata(struct i2c_client *client)
> +{
> +	struct ov2659_platform_data *pdata;
> +	struct device_node *endpoint;
> +	int ret;
> +
> +	if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node) {
> +		dev_err(&client->dev, "ov2659_get_pdata: DT Node found\n");

ov2659_get_pdata: DT Node *not* found...?

-- 
Varka Bhadram