From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbbCTNe6 (ORCPT ); Fri, 20 Mar 2015 09:34:58 -0400 Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:45352 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbbCTNex (ORCPT ); Fri, 20 Mar 2015 09:34:53 -0400 Message-ID: <550C21F4.5040502@xs4all.nl> Date: Fri, 20 Mar 2015 14:34:44 +0100 From: Hans Verkuil User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Ricardo Ribalda Delgado , Hans Verkuil , Mauro Carvalho Chehab , Arun Kumar K , Sylwester Nawrocki , Sakari Ailus , Antti Palosaari , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart Subject: Re: [PATCH 2/5] media: New flag V4L2_CTRL_FLAG_EXECUTE_ON_WRITE References: <1426778486-21807-1-git-send-email-ricardo.ribalda@gmail.com> <1426778486-21807-3-git-send-email-ricardo.ribalda@gmail.com> In-Reply-To: <1426778486-21807-3-git-send-email-ricardo.ribalda@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/19/2015 04:21 PM, Ricardo Ribalda Delgado wrote: > Create a new flag that represent controls that represent controls that Double 'that represent controls' :-) > its value needs to be passed to the driver even if it has not changed. > > They typically represent actions, like triggering a flash or clearing an > error flag. I would add something like: "So writing to such a control means some action is executed." This ties in a bit better with the name of the flag. Hans > > Signed-off-by: Ricardo Ribalda Delgado > --- > include/uapi/linux/videodev2.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index fbdc360..1e33e10 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -1456,6 +1456,7 @@ struct v4l2_querymenu { > #define V4L2_CTRL_FLAG_WRITE_ONLY 0x0040 > #define V4L2_CTRL_FLAG_VOLATILE 0x0080 > #define V4L2_CTRL_FLAG_HAS_PAYLOAD 0x0100 > +#define V4L2_CTRL_FLAG_EXECUTE_ON_WRITE 0x0200 > > /* Query flags, to be ORed with the control ID */ > #define V4L2_CTRL_FLAG_NEXT_CTRL 0x80000000 >