From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752182AbbCTNn3 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Mar 2015 09:43:29 -0400
Received: from mx02.posteo.de ([89.146.194.165]:41639 "EHLO mx02.posteo.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751539AbbCTNnZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Mar 2015 09:43:25 -0400
Message-ID: <550C23E7.500@posteo.de>
Date: Fri, 20 Mar 2015 14:43:03 +0100
From: Martin Kepplinger <martink@posteo.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0
MIME-Version: 1.0
To: Varka Bhadram <varkabhadram@gmail.com>, mark.rutland@arm.com,
        robh+dt@kernel.org, Pawel.Moll@arm.com, ijc+devicetree@hellion.org.uk,
        galak@codeaurora.org, dmitry.torokhov@gmail.com,
        alexander.stein@systec-electronic.com
CC: hadess@hadess.net, akpm@linux-foundation.org, gregkh@linuxfoundation.org,
        linux-api@vger.kernel.org, devicetree@vger.kernel.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Martin Kepplinger <martin.kepplinger@theobroma-systems.com>,
        Christoph Muellner <christoph.muellner@theobroma-systems.com>
Subject: Re: [PATCH v4] add support for Freescale's MMA8653FC 10 bit accelerometer
References: <1426850431-31550-1-git-send-email-martink@posteo.de> <550C0502.7090507@gmail.com>
In-Reply-To: <550C0502.7090507@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2015-03-20 um 12:31 schrieb Varka Bhadram:
> On 03/20/2015 04:50 PM, Martin Kepplinger wrote:
>> From: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
>>
( ...)
>> +    return 0;
>> +
>> + err_free_irq:
>> +    if (mma->irq)
>> +        free_irq(mma->irq, mma);
>> + err_free_mem:
>> +    kfree(mma);
> 
> If we use devm_* API's above steps are not required
> 
>> + err_out:
>> +    return err;
>> +}
>> +
>> +static int mma8653fc_remove(struct i2c_client *client)
>> +{
>> +    struct mma8653fc *mma = i2c_get_clientdata(client);
>> +
>> +    free_irq(mma->irq, mma);
>> +    dev_dbg(&client->dev, "unregistered accelerometer\n");
>> +    kfree(mma);
> 
> same as above..
> 

thanks!