From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbbCTO12 (ORCPT ); Fri, 20 Mar 2015 10:27:28 -0400 Received: from service87.mimecast.com ([91.220.42.44]:56430 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbbCTO1V convert rfc822-to-8bit (ORCPT ); Fri, 20 Mar 2015 10:27:21 -0400 Message-ID: <550C2E5C.70708@arm.com> Date: Fri, 20 Mar 2015 14:27:40 +0000 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Laurent Pinchart CC: Sudeep Holla , Felipe Balbi , "linux-usb@vger.kernel.org" , Dan Carpenter , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start References: <1426851737-24999-1-git-send-email-sudeep.holla@arm.com> <14712088.dyzVQIQYao@avalon> In-Reply-To: <14712088.dyzVQIQYao@avalon> X-OriginalArrivalTime: 20 Mar 2015 14:27:15.0134 (UTC) FILETIME=[F64D55E0:01D06319] X-MC-Unique: 115032014271704501 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On 20/03/15 14:20, Laurent Pinchart wrote: > Hi Sudeep, > > Thank you for the patch. > > On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: >> Commit a124820de5fd ("usb: isp1760: fix possible deadlock in >> isp1760_udc_irq") replaced spin_{un,}lock with >> spin_{un,}lock_irq{save,restore}. However it missed an error path resulting >> in the smatch warning as below: >> >> drivers/usb/isp1760/isp1760-udc.c:1230 isp1760_udc_start() warn: >> inconsistent returns 'irqsave:flags'. Locked on: line 1207 >> Unlocked on: line 1199 >> >> This patch fixes the spin unlock in the error path in isp1760_udc_start >> thereby removing the smatch warning mentioned above. >> >> Reported-by: Dan Carpenter >> Cc: Laurent Pinchart >> Cc: Felipe Balbi >> Signed-off-by: Sudeep Holla > > Acked-by: Laurent Pinchart > Thanks >> --- >> drivers/usb/isp1760/isp1760-udc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Hi Laurent, Felipe, >> >> I am extremely sorry for missing this in my original patch. > > I hope you will be ashamed for the 7 generations to come for this totally > unacceptable low quality standard. > Yes ;) Regards, Sudeep