From: Brian Russell <brian.russell@brocade.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Brian Russell <brussell@brocade.com>
Cc: "Hans J. Koch" <hjk@hansjkoch.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] uio: Fix uio driver to refcount device
Date: Fri, 20 Mar 2015 14:55:28 +0000 [thread overview]
Message-ID: <550C34E0.8090603@brocade.com> (raw)
In-Reply-To: <20150320121812.GA26764@kroah.com>
On 20/03/15 12:18, Greg Kroah-Hartman wrote:
> On Thu, Mar 19, 2015 at 05:55:28PM +0000, Brian Russell wrote:
>> Protect uio driver from its owner being unplugged while there are open fds.
>> Embed struct device in struct uio_device, use refcounting on device, free
>> uio_device on release.
>> info struct passed in uio_register_device can be freed on unregister, so null
>> out the field in uio_unregister_device and check accesses.
>>
>> Signed-off-by: Brian Russell <brussell@brocade.com>
>> ---
>> drivers/uio/uio.c | 58 +++++++++++++++++++++++++++++++---------------
>> include/linux/uio_driver.h | 2 +-
>> 2 files changed, 40 insertions(+), 20 deletions(-)
>
> This patch is line-wrapped and can not be applied :(
>
> Please fix up your email client and resend. I've applied the first
> patch, which worked just fine, no need to resend it.
>
Sorry about that, I've resent. Thanks for the review.
Brian
> thanks,
>
> greg k-h
>
prev parent reply other threads:[~2015-03-20 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 17:55 [PATCH 2/2] uio: Fix uio driver to refcount device Brian Russell
2015-03-20 12:18 ` Greg Kroah-Hartman
2015-03-20 14:55 ` Brian Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C34E0.8090603@brocade.com \
--to=brian.russell@brocade.com \
--cc=brussell@brocade.com \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox