From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbbCTPGP (ORCPT ); Fri, 20 Mar 2015 11:06:15 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:35578 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbbCTPGL (ORCPT ); Fri, 20 Mar 2015 11:06:11 -0400 From: "Grygorii.Strashko@linaro.org" X-Google-Original-From: "Grygorii.Strashko@linaro.org" Message-ID: <550C375A.5040802@linaro.org> Date: Fri, 20 Mar 2015 17:06:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Tony Lindgren CC: Javier Martinez Canillas , Linus Walleij , Alexandre Courbot , ssantosh@kernel.org, Kevin Hilman , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] gpio: omap: convert gpio irq functions to use GPIO offset References: <1426785944-17255-1-git-send-email-grygorii.strashko@linaro.org> <1426785944-17255-6-git-send-email-grygorii.strashko@linaro.org> <20150319230334.GQ31346@atomide.com> In-Reply-To: <20150319230334.GQ31346@atomide.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2015 01:03 AM, Tony Lindgren wrote: > * grygorii.strashko@linaro.org [150319 10:26]: >> From: Grygorii Strashko >> >> Convert GPIO IRQ functions to use GPIO offset instead of system >> GPIO numbers. This allows to drop unneeded conversations between >> system GPIO <-> GPIO offset which are done in many places and >> many times. >> It is safe to do now because: >> - gpiolib always passes GPIO offset to GPIO controller >> - OMAP GPIO driver converted to use IRQ domain, so >> struct irq_data->hwirq contains GPIO offset >> >> This is preparation step before removing: >> #define GPIO_INDEX(bank, gpio) >> #define GPIO_BIT(bank, gpio) >> int omap_irq_to_gpio() > ... > >> static void omap_gpio_unmask_irq(struct irq_data *d) >> { >> struct gpio_bank *bank = omap_irq_data_get_bank(d); >> - unsigned int gpio = omap_irq_to_gpio(bank, d->hwirq); >> + unsigned offset = d->hwirq; >> unsigned int irq_mask = GPIO_BIT(bank, gpio); >> u32 trigger = irqd_get_trigger_type(d); >> unsigned long flags; > > This series up to this patch produces a build error that > would break git bisect: > > drivers/gpio/gpio-omap.c: In function ‘omap_gpio_unmask_irq’: > drivers/gpio/gpio-omap.c:866:37: error: ‘gpio’ undeclared (first use in this function) > unsigned int irq_mask = GPIO_BIT(bank, gpio); Oh. Thanks for catching that :) - splitting/rebasing issue. -- regards, -grygorii