From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbbCTPLm (ORCPT ); Fri, 20 Mar 2015 11:11:42 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:34586 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbbCTPLc (ORCPT ); Fri, 20 Mar 2015 11:11:32 -0400 From: "Grygorii.Strashko@linaro.org" X-Google-Original-From: "Grygorii.Strashko@linaro.org" Message-ID: <550C389B.2020506@linaro.org> Date: Fri, 20 Mar 2015 17:11:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Tony Lindgren CC: Javier Martinez Canillas , Linus Walleij , Alexandre Courbot , ssantosh@kernel.org, Kevin Hilman , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Aaro Koskinen Subject: Re: [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations References: <1426785944-17255-1-git-send-email-grygorii.strashko@linaro.org> <20150319230025.GO31346@atomide.com> In-Reply-To: <20150319230025.GO31346@atomide.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2015 01:00 AM, Tony Lindgren wrote: > * grygorii.strashko@linaro.org [150319 10:26]: >> From: Grygorii Strashko >> >> Now in TI OMAP GPIO driver there are a lot of places where >> System GPIO number calculated and then converted to GPIO offset. >> What is worse is that in many place such conversation performed twice >> or even three times. But actually, we don't need to do that at all, because >> - gpiolib always passes GPIO offset to GPIO controller >> - OMAP GPIO driver converted to use IRQ domain, so >> struct irq_data->hwirq contains GPIO offset >> >> Hence, it is safe to convert all GPIO OMAP functions to use GPIO >> offset instead of system GPIO numbers. Also, this allows to remove >> unneeded conversations routines >> #define GPIO_INDEX(bank, gpio) >> #define GPIO_BIT(bank, gpio) >> int omap_irq_to_gpio() > > Right on! This is excellent news. I've tested this set on top of -rc4 > plus the patch mentioned below, and I'm not seeing regressions on > the platforms I tested with. Wake up to smsc911x ping with off-idle > still works on omap3. > > I only briefly tested on omap1 (osk5912), so I'like to wait for > Aaro's ack before this gets merged. > > I found one build error, other than that, for the whole series > please feel free to add: > > Tested-by: Tony Lindgren Thanks Tony. Yep. I'll wait for news from Aaro then will re-send if ok. -- regards, -grygorii