[linux-next] Warning from fs/sysfs/group.c:102

[linux-next] Warning from fs/sysfs/group.c:102

[Steven Rostedt]

I decided to run my tracing tests on linux-next and they failed with
the following warning:

[drm] Initialized i915 1.6.0 20150130 for 0000:00:02.0 on minor 0
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at /home/rostedt/work/git/linux-trace.git/fs/sysfs/group.c:102 internal_create_group+0x77/0x1b9()
sysfs: (bin_)attrs not set by subsystem for group: index3/
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.0.0-rc4-test+ #59
Hardware name: MSI MS-7823/CSM-H87M-G43 (MS-7823), BIOS V1.6 02/22/2014
 00000000 00000000 f2e47db0 c0ca3069 c1025b72 f2e47de0 c043ccfe c1025baa
 f2e47e0c 00000001 c1025b72 00000066 c05808fe c05808fe c115e4c8 ffffffea
 f10ed808 f2e47df8 c043cda0 00000009 f2e47df0 c1025baa f2e47e0c f2e47e30
Call Trace:
 [<c0ca3069>] dump_stack+0x41/0x52
 [<c043ccfe>] warn_slowpath_common+0x9d/0xb4
 [<c05808fe>] ? internal_create_group+0x77/0x1b9
 [<c05808fe>] ? internal_create_group+0x77/0x1b9
 [<c043cda0>] warn_slowpath_fmt+0x33/0x35
 [<c05808fe>] internal_create_group+0x77/0x1b9
 [<c0580a67>] sysfs_create_group+0x11/0x13
 [<c0580b32>] sysfs_create_groups+0x23/0x51
 [<c08f827b>] device_add+0x20d/0x4cf
 [<c0526893>] ? kfree+0x46/0xf5
 [<c08fc64d>] cpu_device_create+0x5b/0x77
 [<c08fe803>] cache_add_dev+0x142/0x193
 [<c1280095>] cacheinfo_sysfs_init+0x2d/0x7f
 [<c0400491>] do_one_initcall+0x10a/0x1a5
 [<c1280068>] ? container_dev_init+0x30/0x30
 [<c1280068>] ? container_dev_init+0x30/0x30
 [<c0452e8a>] ? parse_args+0x272/0x388
 [<c1239cc1>] kernel_init_freeable+0x184/0x22b
 [<c12394bc>] ? do_early_param+0x74/0x74
 [<c0c9c259>] kernel_init+0x10/0xd0
 [<c045b9d6>] ? schedule_tail+0x11/0x4d
 [<c0cad241>] ret_from_kernel_thread+0x21/0x30
 [<c0c9c249>] ? rest_init+0x11d/0x11d
---[ end trace 8b432669a035454b ]---
error populating cacheinfo..cpu0

Doing a git bisect, it ended on this commit:

commit 0d55ba46bfbee64fd2b492b87bfe2ec172e7b056
Author: Sudeep Holla <sudeep.holla@arm.com>
Date:   Wed Mar 4 12:00:16 2015 +0000
Subject: x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure

Reverting this commit makes the warning go away.

-- Steve

    

Re: [linux-next] Warning from fs/sysfs/group.c:102

[Sudeep Holla]

Hi Steven,

On 20/03/15 17:32, Steven Rostedt wrote:
>
> I decided to run my tracing tests on linux-next and they failed with
> the following warning:
>
> [drm] Initialized i915 1.6.0 20150130 for 0000:00:02.0 on minor 0
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at /home/rostedt/work/git/linux-trace.git/fs/sysfs/group.c:102 internal_create_group+0x77/0x1b9()
> sysfs: (bin_)attrs not set by subsystem for group: index3/

It should be fixed by the patch posted[1].
Boris will soon push that to tip[2].

Regards,
Sudeep

[1] https://lkml.org/lkml/2015/3/10/342
[2] https://lkml.org/lkml/2015/3/19/178

Re: [linux-next] Warning from fs/sysfs/group.c:102

[Steven Rostedt]

On Fri, 20 Mar 2015 17:37:28 +0000
Sudeep Holla <sudeep.holla@arm.com> wrote:

 
> It should be fixed by the patch posted[1].
> Boris will soon push that to tip[2].

Ah, so you are already aware. Thanks.

/me goes to bisect the next crash that is in next.

-- Steve