From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Andrew Morton <akpm@linux-foundation.org>,
Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
David Howells <dhowells@redhat.com>,
Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event()
Date: Sat, 21 Mar 2015 02:15:17 +0100 [thread overview]
Message-ID: <550CC625.9090003@gmx.de> (raw)
In-Reply-To: <550CC2D1.9070305@gmx.de>
On 21.03.2015 02:01, Lino Sanfilippo wrote:
>> Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)?
>>
>
> No, the current logic should be correct, since we want events for
> directories if we have FS_ISDIR set in the marks mask but not in its
> ignored_mask.
>
Actually this should be: "... since we ONLY want events for directories
if we have FS_ISDIR set in the marks mask but not in its ignored_mask".
With Fabians Code we could even get events for dirs although FAN_ONDIR
has not been set - which is not what we want.
next prev parent reply other threads:[~2015-03-21 1:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 20:56 [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event() Fabian Frederick
2015-03-20 21:09 ` Andrew Morton
2015-03-20 21:16 ` Fabian Frederick
2015-03-21 1:01 ` Lino Sanfilippo
2015-03-21 1:15 ` Lino Sanfilippo [this message]
2015-03-22 9:46 ` Fabian Frederick
2015-03-22 10:48 ` Lino Sanfilippo
2015-04-01 8:59 ` Jan Kara
2015-03-21 0:56 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550CC625.9090003@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=eparis@redhat.com \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox