From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752938AbbCUBP3 (ORCPT ); Fri, 20 Mar 2015 21:15:29 -0400 Received: from mout.gmx.net ([212.227.15.18]:60175 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbbCUBP0 (ORCPT ); Fri, 20 Mar 2015 21:15:26 -0400 Message-ID: <550CC625.9090003@gmx.de> Date: Sat, 21 Mar 2015 02:15:17 +0100 From: Lino Sanfilippo User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Morton , Fabian Frederick CC: linux-kernel@vger.kernel.org, Jan Kara , David Howells , Eric Paris Subject: Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event() References: <1426884968-1747-1-git-send-email-fabf@skynet.be> <20150320140943.9cca246285c4fa21b7621872@linux-foundation.org> <550CC2D1.9070305@gmx.de> In-Reply-To: <550CC2D1.9070305@gmx.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:p8owg2TF1HJNi6brIgpYpHYuw9Yk1RErtbhyfhhM3N91eYavcQs Tw10ztbr88DREmkvBWCRR3HDEDEOaFERBGMUb1UlPCoYwaSSqP8G8CQgzzOvhnkxyE0V8az yZ2Pgcu5RKKPMM5HuT4vyotaDMQ9IL6gKOtGFnHdU8APlZPdtd2MA8+beWNuzALKfGpjXnT aC6+q1TlFjLtpJf4sA+4A== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.03.2015 02:01, Lino Sanfilippo wrote: >> Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)? >> > > No, the current logic should be correct, since we want events for > directories if we have FS_ISDIR set in the marks mask but not in its > ignored_mask. > Actually this should be: "... since we ONLY want events for directories if we have FS_ISDIR set in the marks mask but not in its ignored_mask". With Fabians Code we could even get events for dirs although FAN_ONDIR has not been set - which is not what we want.