From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbbCUBhs (ORCPT ); Fri, 20 Mar 2015 21:37:48 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:36524 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbbCUBhr (ORCPT ); Fri, 20 Mar 2015 21:37:47 -0400 Message-ID: <550CCB67.5010008@roeck-us.net> Date: Fri, 20 Mar 2015 18:37:43 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Mathieu Olivari , davem@davemloft.net, f.fainelli@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: make NET_DSA manually selectable from the config References: <1426901463-31913-1-git-send-email-mathieu@codeaurora.org> In-Reply-To: <1426901463-31913-1-git-send-email-mathieu@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.550CCB6A.00F8,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2015 06:31 PM, Mathieu Olivari wrote: > Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers > depend on NET_DSA rather than selecting them. However, as the only way > to select this option was to actually select a driver, it made DSA > impossible to enable at all. > > This patch adds an explicit entry which the user will have to enable > prior selecting a driver. > Fixes: bd76a116707b ("dsa: change "select" to "depends on" for NET_SWITCHDEV and for NET_DSA") > Signed-off-by: Mathieu Olivari Andrew found the same problem yesterday and was about to submit the same patch... Reviewed-by: Guenter Roeck > --- > net/dsa/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig > index 087e654..4f3cce1 100644 > --- a/net/dsa/Kconfig > +++ b/net/dsa/Kconfig > @@ -5,9 +5,12 @@ config HAVE_NET_DSA > # Drivers must select NET_DSA and the appropriate tagging format > > config NET_DSA > - tristate > + tristate "Distributed Switch Architecture" > depends on HAVE_NET_DSA && NET_SWITCHDEV > select PHYLIB > + ---help--- > + Say Y if you want to enable support for the hardware switches supported > + by the Distributed Switch Architecture. > > if NET_DSA > >