From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751922AbbCUCff (ORCPT ); Fri, 20 Mar 2015 22:35:35 -0400 Received: from mail-by2on0114.outbound.protection.outlook.com ([207.46.100.114]:19648 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751191AbbCUCfd (ORCPT ); Fri, 20 Mar 2015 22:35:33 -0400 X-WSS-ID: 0NLJJ73-08-ZZO-02 X-M-MSG: Message-ID: <550CD8EE.4090504@amd.com> Date: Fri, 20 Mar 2015 21:35:26 -0500 From: Aravind Gopalakrishnan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Luck, Tony" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "bp@alien8.de" , "slaoub@gmail.com" , "luto@amacapital.net" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer References: <1426869068-4155-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1426869068-4155-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <3908561D78D1C84285E8C5FCA982C28F32A267D3@ORSMSX114.amr.corp.intel.com> In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32A267D3@ORSMSX114.amr.corp.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Aravind.Gopalakrishnan@amd.com; alien8.de; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(189002)(24454002)(164054003)(479174004)(377454003)(51704005)(199003)(50986999)(54356999)(101416001)(76176999)(50466002)(65816999)(87266999)(2501003)(106466001)(83506001)(107886001)(33656002)(2950100001)(92566002)(105586002)(47776003)(23746002)(65956001)(77096005)(2201001)(62966003)(77156002)(86362001)(36756003)(46102003)(87936001)(59896002)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB409;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB409; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010);SRVR:BY2PR02MB409;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB409; X-Forefront-PRVS: 05220145DE X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2015 02:35:29.2116 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB409 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/20/15 5:31 PM, Luck, Tony wrote: > + default: > + WARN_ONCE(1, "WTF!?"); > + break; > > You meant to type: > > mce_severity = mce_severity_default; > > just there, right? > Other function pointers in the mce code like unexpected_machine_check and default_threshold_interrupt are assigned to the respective function pointers when they are defined. So, I just followed a similar assignment for mce_severity_default. I can do that in the default statement if you prefer. Thanks, -Aravind.