From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751397AbbCUDRq (ORCPT ); Fri, 20 Mar 2015 23:17:46 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:33183 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbbCUDRn (ORCPT ); Fri, 20 Mar 2015 23:17:43 -0400 Message-ID: <550CE2CE.4080508@linaro.org> Date: Sat, 21 Mar 2015 11:17:34 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Will Deacon , Hanjun Guo CC: Catalin Marinas , "Rafael J. Wysocki" , Olof Johansson , "grant.likely@linaro.org" , Lorenzo Pieralisi , Arnd Bergmann , Mark Rutland , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Marc Zyngier , Mark Brown , Robert Richter , Timur Tabi , Ashwin Chaugule , "suravee.suthikulpanit@amd.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , Parth Dixit , "'Stefano Stabellini'" Subject: Re: [PATCH v10 00/21] Introduce ACPI for ARM64 based on ACPI 5.1 References: <1426077587-1561-1-git-send-email-hanjun.guo@linaro.org> <20150318190509.GM10863@arm.com> <550A4BFD.4070804@huawei.com> <20150320185400.GK1474@arm.com> In-Reply-To: <20150320185400.GK1474@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +CC Parth Dixit, Stefano Stabellini. On 2015年03月21日 02:54, Will Deacon wrote: > On Thu, Mar 19, 2015 at 04:09:33AM +0000, Hanjun Guo wrote: >> On 2015/3/19 3:05, Will Deacon wrote: >>> If you can get that in place, I'm not opposed to putting this into >>> linux-next ahead of the firmware summit in San Jose next week. Note that >>> this is not a commitment for 4.1, since I'm keen to see the outcomes of >>> next week before setting anything in stone. >> >> OK, I will stick to this mailing list and respond as soon as I can. > > This doesn't even build for me: > > > $ make ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- allmodconfig > $ make ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- Image > > [...] > > In file included from drivers/xen/acpi.c:33:0: Sorry, I didn't build ACPI with XEN enabled on ARM64. > include/xen/acpi.h: In function ‘xen_acpi_sleep_register’: > include/xen/acpi.h:102:3: error: ‘acpi_suspend_lowlevel’ undeclared (first use in this function) > acpi_suspend_lowlevel = xen_acpi_suspend_lowlevel; acpi_suspend_lowlevel is defined only for X86 and IA64 for now. > ^ > include/xen/acpi.h:102:3: note: each undeclared identifier is reported only once for each function it appears in > drivers/xen/acpi.c: In function ‘xen_acpi_notify_hypervisor_state’: > drivers/xen/acpi.c:61:2: error: implicit declaration of function ‘HYPERVISOR_dom0_op’ [-Werror=implicit-function-declaration] > HYPERVISOR_dom0_op(&op); And this is only for x86: ./arch/x86/include/asm/xen/hypercall.h:HYPERVISOR_dom0_op(struct xen_platform_op *platform_op) > ^ > cc1: some warnings being treated as errors > make[2]: *** [drivers/xen/acpi.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [drivers/xen] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [drivers] Error 2 > > > Am I missing some other patches? No, you miss nothing. Parth Dixit is still working on XEN ACPI for ARM64, before it's in full function, how about introduce a Kconfig CONFIG_XEN_ACPI and let it depends on x86? when XEN ACPI for ARM64 comes, we can enable ARM64 for CONFIG_XEN_ACPI and fix the problems above. Stefano, Parth, what do you think? Thanks Hanjun