From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752006AbbCUMQN (ORCPT ); Sat, 21 Mar 2015 08:16:13 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:51081 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbbCUMQM (ORCPT ); Sat, 21 Mar 2015 08:16:12 -0400 Message-ID: <550D6103.9090001@hitachi.com> Date: Sat, 21 Mar 2015 21:16:03 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Alexei Starovoitov CC: Ingo Molnar , Steven Rostedt , Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa , "David S. Miller" , Daniel Borkmann , Peter Zijlstra , linux-api@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 tip 2/9] tracing: add kprobe flag References: <1426894210-27441-1-git-send-email-ast@plumgrid.com> <1426894210-27441-3-git-send-email-ast@plumgrid.com> In-Reply-To: <1426894210-27441-3-git-send-email-ast@plumgrid.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2015/03/21 8:30), Alexei Starovoitov wrote: > add TRACE_EVENT_FL_KPROBE flag to differentiate kprobe type of tracepoints, > since bpf programs can only be attached to kprobe type of > PERF_TYPE_TRACEPOINT perf events. > Looks ok to me. Reviewed-by: Thank you! > Signed-off-by: Alexei Starovoitov > Reviewed-by: Steven Rostedt > --- > include/linux/ftrace_event.h | 3 +++ > kernel/trace/trace_kprobe.c | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h > index c674ee8f7fca..77325e1a1816 100644 > --- a/include/linux/ftrace_event.h > +++ b/include/linux/ftrace_event.h > @@ -252,6 +252,7 @@ enum { > TRACE_EVENT_FL_WAS_ENABLED_BIT, > TRACE_EVENT_FL_USE_CALL_FILTER_BIT, > TRACE_EVENT_FL_TRACEPOINT_BIT, > + TRACE_EVENT_FL_KPROBE_BIT, > }; > > /* > @@ -265,6 +266,7 @@ enum { > * it is best to clear the buffers that used it). > * USE_CALL_FILTER - For ftrace internal events, don't use file filter > * TRACEPOINT - Event is a tracepoint > + * KPROBE - Event is a kprobe > */ > enum { > TRACE_EVENT_FL_FILTERED = (1 << TRACE_EVENT_FL_FILTERED_BIT), > @@ -274,6 +276,7 @@ enum { > TRACE_EVENT_FL_WAS_ENABLED = (1 << TRACE_EVENT_FL_WAS_ENABLED_BIT), > TRACE_EVENT_FL_USE_CALL_FILTER = (1 << TRACE_EVENT_FL_USE_CALL_FILTER_BIT), > TRACE_EVENT_FL_TRACEPOINT = (1 << TRACE_EVENT_FL_TRACEPOINT_BIT), > + TRACE_EVENT_FL_KPROBE = (1 << TRACE_EVENT_FL_KPROBE_BIT), > }; > > struct ftrace_event_call { > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index d73f565b4e06..8fa549f6f528 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -1286,7 +1286,7 @@ static int register_kprobe_event(struct trace_kprobe *tk) > kfree(call->print_fmt); > return -ENODEV; > } > - call->flags = 0; > + call->flags = TRACE_EVENT_FL_KPROBE; > call->class->reg = kprobe_register; > call->data = tk; > ret = trace_add_event_call(call); > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com