From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbbCUMRH (ORCPT ); Sat, 21 Mar 2015 08:17:07 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:43594 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbbCUMRE (ORCPT ); Sat, 21 Mar 2015 08:17:04 -0400 Message-ID: <550D6137.2040509@hitachi.com> Date: Sat, 21 Mar 2015 21:16:55 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Alexei Starovoitov CC: Ingo Molnar , Steven Rostedt , Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa , "David S. Miller" , Daniel Borkmann , Peter Zijlstra , linux-api@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 tip 1/9] bpf: make internal bpf API independent of CONFIG_BPF_SYSCALL ifdefs References: <1426894210-27441-1-git-send-email-ast@plumgrid.com> <1426894210-27441-2-git-send-email-ast@plumgrid.com> In-Reply-To: <1426894210-27441-2-git-send-email-ast@plumgrid.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2015/03/21 8:30), Alexei Starovoitov wrote: > From: Daniel Borkmann > > Socket filter code and other subsystems with upcoming eBPF support should > not need to deal with the fact that we have CONFIG_BPF_SYSCALL defined or > not. > > Having the bpf syscall as a config option is a nice thing and I'd expect > it to stay that way for expert users (I presume one day the default setting > of it might change, though), but code making use of it should not care if > it's actually enabled or not. > > Instead, hide this via header files and let the rest deal with it. > Looks good to me. Reviewed-by: Masami Hiramatsu Thank you, > Signed-off-by: Daniel Borkmann > Signed-off-by: Alexei Starovoitov > --- > include/linux/bpf.h | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h > index bbfceb756452..c2e21113ecc0 100644 > --- a/include/linux/bpf.h > +++ b/include/linux/bpf.h > @@ -113,8 +113,6 @@ struct bpf_prog_type_list { > enum bpf_prog_type type; > }; > > -void bpf_register_prog_type(struct bpf_prog_type_list *tl); > - > struct bpf_prog; > > struct bpf_prog_aux { > @@ -129,11 +127,25 @@ struct bpf_prog_aux { > }; > > #ifdef CONFIG_BPF_SYSCALL > +void bpf_register_prog_type(struct bpf_prog_type_list *tl); > + > void bpf_prog_put(struct bpf_prog *prog); > +struct bpf_prog *bpf_prog_get(u32 ufd); > #else > -static inline void bpf_prog_put(struct bpf_prog *prog) {} > +static inline void bpf_register_prog_type(struct bpf_prog_type_list *tl) > +{ > +} > + > +static inline struct bpf_prog *bpf_prog_get(u32 ufd) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline void bpf_prog_put(struct bpf_prog *prog) > +{ > +} > #endif > -struct bpf_prog *bpf_prog_get(u32 ufd); > + > /* verify correctness of eBPF program */ > int bpf_check(struct bpf_prog *fp, union bpf_attr *attr); > > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com