From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751638AbbCUV7j (ORCPT ); Sat, 21 Mar 2015 17:59:39 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:34668 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbbCUV7h (ORCPT ); Sat, 21 Mar 2015 17:59:37 -0400 Message-ID: <550DE9A1.1050200@oracle.com> Date: Sat, 21 Mar 2015 16:58:57 -0500 From: Dave Kleikamp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Richard Weinberger , shaggy@kernel.org CC: jfs-discussion@lists.sourceforge.net, linux-fsdevel , Al Viro , lists@nerdbynature.de, ben@decadent.org.uk, stable , hmage@hmage.net, "linux-kernel@vger.kernel.org" Subject: Re: JFS readdir() issues in stable 3.2 References: <550CAE5C.9010101@nod.at> In-Reply-To: <550CAE5C.9010101@nod.at> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2015 06:33 PM, Richard Weinberger wrote: > Hi! > > Mainline commit 44512449c0ab368889dd13ae0031fba74ee7e1d2 > (jfs: fix readdir cookie incompatibility with NFSv4) does not work as expected on 3.2. > Maybe on other stable kernels too. > > UML stumbled over it: > https://bugzilla.kernel.org/show_bug.cgi?id=94741 > > If you run the attached readdir.c on a JFS on stable 3.2.51+ readdir() will not > increment the directory offset nor return NULL, hence the caller will loop forever. > It looks like if the current directory offset is > 0 and you run seekdir(telldir()) > the next readdir() call will not increment it. The backport failed to pass the proper position to filldir() for the . and .. entries. I've attached a proposed patch to the above bug. > > Dave, has your fix some unnamed dependencies which need backporting too? > > Thanks, > //richard Thanks! Shaggy