From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751869AbbCVKsd (ORCPT ); Sun, 22 Mar 2015 06:48:33 -0400 Received: from mout.gmx.net ([212.227.17.22]:53571 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbbCVKsa (ORCPT ); Sun, 22 Mar 2015 06:48:30 -0400 Message-ID: <550E9DF4.7@gmx.de> Date: Sun, 22 Mar 2015 11:48:20 +0100 From: Lino Sanfilippo User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Fabian Frederick , Andrew Morton CC: Eric Paris , linux-kernel@vger.kernel.org, David Howells , Jan Kara Subject: Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event() References: <1426884968-1747-1-git-send-email-fabf@skynet.be> <20150320140943.9cca246285c4fa21b7621872@linux-foundation.org> <550CC2D1.9070305@gmx.de> <550CC625.9090003@gmx.de> <1702390928.185057.1427017594441.open-xchange@webmail.nmp.proximus.be> In-Reply-To: <1702390928.185057.1427017594441.open-xchange@webmail.nmp.proximus.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:LdQHhm1Eb0R1c6r0+fSrqHmKXcRfglvMEg+a1XBHbq3Lak1JYuc MW6ZwcmmrUoNYlXcqvm+v8JANFc+mNCF2obXp439q8GLTx2iV63vycYxykWHHb8rtjvu17P GYKfrWBYds9ECh7U0M0qHMCViASva6rY83YyuDwsRvIu/+Tmkq4K5CchxW3kJU5IXTlqBSh WuLhlJEygya6DVjLQ2apw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.03.2015 10:46, Fabian Frederick wrote: > Let's hope it only breaks ltp tests and no _real_ userland stuff > (search systems ...) > > Regards, > Fabian > Hi Fabian, yes, that worries me too. I know that there have been discussions on lkml in which it was made clear that userspace breakage is frowned upon. And it is obvious, that the latest changes concerning the handling of FAN_ONDIR are also visible to userspace. But since the concerning patches have been accepted I think it is ok. I could be wrong though. Maybe someone with a deeper knowledge of kernel policy/guidelines could comment on this? Regards, Lino