From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751899AbbCVSFo (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 Mar 2015 14:05:44 -0400
Received: from mail-ig0-f180.google.com ([209.85.213.180]:38218 "EHLO
	mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751827AbbCVSFl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 Mar 2015 14:05:41 -0400
Message-ID: <550F0475.7020206@plumgrid.com>
Date: Sun, 22 Mar 2015 11:05:41 -0700
From: Alexei Starovoitov <ast@plumgrid.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Ingo Molnar <mingo@kernel.org>
CC: Steven Rostedt <rostedt@goodmis.org>, Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        "David S. Miller" <davem@davemloft.net>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-api@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()
References: <1426894210-27441-1-git-send-email-ast@plumgrid.com> <1426894210-27441-6-git-send-email-ast@plumgrid.com> <20150322111040.GA18695@gmail.com>
In-Reply-To: <20150322111040.GA18695@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/22/15 4:10 AM, Ingo Molnar wrote:
>
> * Alexei Starovoitov <ast@plumgrid.com> wrote:
>
>> +static const struct bpf_func_proto bpf_trace_printk_proto = {
>> +	.func = bpf_trace_printk,
>> +	.gpl_only = true,
>> +	.ret_type = RET_INTEGER,
>> +	.arg1_type = ARG_PTR_TO_STACK,
>> +	.arg2_type = ARG_CONST_STACK_SIZE,
>> +};
>
> A nit, please align such initializations vertically, for more
> readability:
>
> static const struct bpf_func_proto bpf_trace_printk_proto = {
> 	.func		= bpf_trace_printk,
> 	.gpl_only	= true,
> 	.ret_type	= RET_INTEGER,
> 	.arg1_type	= ARG_PTR_TO_STACK,
> 	.arg2_type	= ARG_CONST_STACK_SIZE,
> };

sure. will respin.