From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbbCVWpl (ORCPT ); Sun, 22 Mar 2015 18:45:41 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:55168 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbbCVWpj (ORCPT ); Sun, 22 Mar 2015 18:45:39 -0400 Message-ID: <550F460F.8060705@roeck-us.net> Date: Sun, 22 Mar 2015 15:45:35 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: David Miller , andrew@lunn.ch CC: netdev@vger.kernel.org, f.fainelli@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/18] net: dsa: mv88e6xxx: Add Hardware bridging support References: <1426952815-4642-1-git-send-email-linux@roeck-us.net> <1426952815-4642-9-git-send-email-linux@roeck-us.net> <20150322200600.GD15025@lunn.ch> <20150322.182407.1915654260904903040.davem@davemloft.net> In-Reply-To: <20150322.182407.1915654260904903040.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020204.550F4612.00C2,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 1 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22/2015 03:24 PM, David Miller wrote: > From: Andrew Lunn > Date: Sun, 22 Mar 2015 21:06:00 +0100 > >> Hi Guenter >> >>> +static int _mv88e6xxx_atu_cmd(struct dsa_switch *ds, int fid, u16 cmd) >>> +{ >>> + int ret; >>> + >>> + ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x01, fid); >>> + if (ret < 0) >>> + return ret; >> >> Please could you check this. I think register 0x01 here is wrong. I >> think you want 0x0b, the ATU Operations register? > > Just want to mention that register mnenomics would have made this > bug more obvious :-) > Andrew is working on introducing those definitions, which is how he found the problem. It is not a bug per se, though, since the register definition changed across chip generations. The code works fine for the chips we tested it with (6171, 6172, and 6352). Guenter