From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752068AbbCWBqJ (ORCPT ); Sun, 22 Mar 2015 21:46:09 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:59520 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751978AbbCWBqG (ORCPT ); Sun, 22 Mar 2015 21:46:06 -0400 X-AuditID: cbfee68f-f791c6d000004834-2f-550f705cfc7e Message-id: <550F705C.2070101@samsung.com> Date: Mon, 23 Mar 2015 10:46:04 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Dan Carpenter Cc: MyungJoo Ham , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch 1/2] extcon: max77843: signedness bug in max77843_muic_set_debounce_time() References: <20150315104947.GD20691@mwanda> In-reply-to: <20150315104947.GD20691@mwanda> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42JZI2JSohtTwB9qMO2IgsXrf9NZLLbekra4 vGsOm8XtxhVsDiweH5/eYvHo27KK0ePzJrkA5igum5TUnMyy1CJ9uwSujH2XnzMVHGKrWDm9 l7mBcQNrFyMnh4SAicSs89MYIWwxiQv31rN1MXJxCAksZZQ43XGTDabo1fEtjBCJRYwSH79e hnIeMEosv3SCGaSKV0BL4vDud2A2i4CqxNkH68FsNqD4/hc3wCaJCoRJrJx+hQWiXlDix+R7 YLaIgI7E5c4f7F2MHBzMAjkSm3pjQcLCAgkSU14/ACsREtCWmNa6gwnE5gQqvzt3Ith4ZiB7 f+s0NghbXmLzmrfMILdJCCxil7i+6D0bxD0CEt8mH2IBmS8hICux6QAzxGOSEgdX3GCZwCg2 C8lFs5CMnYVk7AJG5lWMoqkFyQXFSelFxnrFibnFpXnpesn5uZsYgTF0+t+z/h2Mdw9YH2IU 4GBU4uHtiOMPFWJNLCuuzD3EaAp0xURmKdHkfGCk5pXEGxqbGVmYmpgaG5lbmimJ8y6U+hks JJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgXHtkZYn3+a+2HEh8YmjycWY8Jc/Tuzg9RF7UfNQ 952tTUt/VsN9q5bQP47dFgxva+d8ZtqzVzh2xh3tWUYxX+Id75gceLj4PIexydy3V3fn/52a 7CTv+/DTdq8VcjeK7zfpL5/cf6FEoyql62Oyz5t5qVc+nrKfoRTMm6qpMH89Z6ran/05r6qV WIozEg21mIuKEwEmj7mZnAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMIsWRmVeSWpSXmKPExsVy+t9jAd2YAv5Qgw+zJCxe/5vOYrH1lrTF 5V1z2CxuN65gc2Dx+Pj0FotH35ZVjB6fN8kFMEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvH m5oZGOoaWlqYKynkJeam2iq5+AToumXmAG1TUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesb EgTXY2SABhLWMGbsu/ycqeAQW8XK6b3MDYwbWLsYOTkkBEwkXh3fwghhi0lcuLeerYuRi0NI YBGjxMevlxkhnAeMEssvnWAGqeIV0JI4vPsdmM0ioCpx9sF6MJsNKL7/xQ02EFtUIExi5fQr LBD1ghI/Jt8Ds0UEdCQud/5g72Lk4GAWyJHY1BsLEhYWSJCY8voBWImQgLbEtNYdTCA2J1D5 3bkTwcYzA9n7W6exQdjyEpvXvGWewCgwC8mGWUjKZiEpW8DIvIpRNLUguaA4KT3XSK84Mbe4 NC9dLzk/dxMjOEKfSe9gXNVgcYhRgINRiYe3I44/VIg1say4MvcQowQHs5IIb6w9UIg3JbGy KrUoP76oNCe1+BCjKTAAJjJLiSbnA5NHXkm8obGJmZGlkbmhhZGxuZI4r5J9W4iQQHpiSWp2 ampBahFMHxMHp1QDY852fubli+6Kym5w3MXxXoRzg2Ku9eur0/yuTPdnq94v6MQlrB+TdY9t +7UOR5P4c1sO96cppssXvmXdJpDxcdFRb20DXR1txbP2N57UnDh4/vfiJU5r1xRfidlesyNw jX/ttjVSr7acOLj3o3AHx7N/DVUZr1x2e9R80hEO7923IphTSHZ+qRJLcUaioRZzUXEiAIyr khvmAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On 03/15/2015 07:49 PM, Dan Carpenter wrote: > "ret" holds negative error codes and zero so it should be signed. > > Fixes: 27a28d32b4f2 ('extcon: max77843: Add max77843 MUIC driver') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c > index 598a017..a3f80ca 100644 > --- a/drivers/extcon/extcon-max77843.c > +++ b/drivers/extcon/extcon-max77843.c > @@ -682,7 +682,7 @@ static int max77843_muic_set_debounce_time(struct max77843_muic_info *info, > enum max77843_muic_adc_debounce_time time) > { > struct max77843 *max77843 = info->max77843; > - unsigned int ret; > + int ret; > > switch (time) { > case MAX77843_DEBOUNCE_TIME_5MS: > Applied it on extcon-next branch. Thanks, Chanwoo Choi