From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbbCWBuB (ORCPT ); Sun, 22 Mar 2015 21:50:01 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:40835 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbbCWBt6 (ORCPT ); Sun, 22 Mar 2015 21:49:58 -0400 X-AuditID: cbfee690-f79ab6d0000046f7-31-550f7144a6ad Message-id: <550F7144.9050608@samsung.com> Date: Mon, 23 Mar 2015 10:49:56 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Dan Carpenter Cc: MyungJoo Ham , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch 2/2] extcon: max77843: fix an error code in max77843_init_muic_regmap() References: <20150315105604.GE20691@mwanda> In-reply-to: <20150315105604.GE20691@mwanda> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgkeLIzCtJLcpLzFFi42JZI2JSqOtayB9q8GsGi8Xrf9NZLLbekra4 vGsOm8XtxhVsDiweH5/eYvHo27KK0ePzJrkA5igum5TUnMyy1CJ9uwSujHXvVjAVtLNXrHwT 3sD4iLWLkZNDQsBE4svCbSwQtpjEhXvr2boYuTiEBJYySky92wlXdHfKLHaIxCJGiW1zFjJD OA8YJZ6s/8AOUsUroCVxZf9GsA4WAVWJXecvs4HYbEDx/S9ugNmiAmESK6dfYYGoF5T4Mfke mC0ioCNxufMH0BwODmaBHIlNvbEgYWGBWIn2zbPASoQEtCX61v0AszmByvfcewu2lhnI3t86 jQ3ClpfYvOYt2G0SAvPYJS5tn8QEcY+AxLfJh1hA5ksIyEpsOsAM8ZikxMEVN1gmMIrNQnLR LCRjZyEZu4CReRWjaGpBckFxUnqRiV5xYm5xaV66XnJ+7iZGYASd/vdswg7GewesDzEKcDAq 8fB2xPGHCrEmlhVX5h5iNAW6YiKzlGhyPjBO80riDY3NjCxMTUyNjcwtzZTEeV9L/QwWEkhP LEnNTk0tSC2KLyrNSS0+xMjEwSnVwCg7xS0sOXbpjVR+J8sMxxPBBXUPV9zRTPW9OKFVYvHS tlfpGYnzN6wW/3VFN/uwbNJ6o92Ll2qt03ngNeHOpWU+6xgS7jjI3WTfLKx2+tpjNqEjItGF zDGdl6f2+XKL75O5dXJ9dX6RyuZVfzLWJTzgDp2mw8A9PzVkEfOs85VXu7fPXrtf57wSS3FG oqEWc1FxIgBW7baTmwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t9jAV2XQv5Qg6OvLC1e/5vOYrH1lrTF 5V1z2CxuN65gc2Dx+Pj0FotH35ZVjB6fN8kFMEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvH m5oZGOoaWlqYKynkJeam2iq5+AToumXmAG1TUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesb EgTXY2SABhLWMGase7eCqaCdvWLlm/AGxkesXYycHBICJhJ3p8xih7DFJC7cW8/WxcjFISSw iFFi25yFzBDOA0aJJ+s/gFXxCmhJXNm/EaybRUBVYtf5y2wgNhtQfP+LG2C2qECYxMrpV1gg 6gUlfky+B2aLCOhIXO78ATSHg4NZIEdiU28sSFhYIFaiffMssBIhAW2JvnU/wGxOoPI9996C rWUGsve3TmODsOUlNq95yzyBUWAWkg2zkJTNQlK2gJF5FaNoakFyQXFSeq6hXnFibnFpXrpe cn7uJkZwfD6T2sG4ssHiEKMAB6MSD29DOH+oEGtiWXFl7iFGCQ5mJRHeWHugEG9KYmVValF+ fFFpTmrxIUZTYABMZJYSTc4Hpo68knhDYxMzI0sjc0MLI2NzJXFeJfu2ECGB9MSS1OzU1ILU Ipg+Jg5OqQbG1INLs3c/53Bm3lySXGB7rOy2vHl47QXJCU2yT22OLWPzcDq37UzhxWk1D7Jz anznHWRren98Qca92TUnWp6FOT40EtvcsHLqzIhvU58cmLXnxzQJObeqfR8FBLWfpVlyvVp1 6eXz/05/tna5TmV2T1Pb8GfvIukb323011zl8DZPflaaq+qrpsRSnJFoqMVcVJwIAP2Ou4zl AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On 03/15/2015 07:56 PM, Dan Carpenter wrote: > "max77843->i2c_muic" is NULL, not an error code. Let's return -ENODEV > here. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c > index a3f80ca..6f0ed5a 100644 > --- a/drivers/extcon/extcon-max77843.c > +++ b/drivers/extcon/extcon-max77843.c > @@ -715,7 +715,7 @@ static int max77843_init_muic_regmap(struct max77843 *max77843) > if (!max77843->i2c_muic) { > dev_err(&max77843->i2c->dev, > "Cannot allocate I2C device for MUIC\n"); > - return PTR_ERR(max77843->i2c_muic); > + return -ENODEV; I think that -ENOMEM is more proper error than -ENODEV. So, I'll use -ENOMEM value and applied it on extcon-next branch. Thanks, Chanwoo Choi > } > > i2c_set_clientdata(max77843->i2c_muic, max77843); >