From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752177AbbCWCWb (ORCPT ); Sun, 22 Mar 2015 22:22:31 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:24647 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbbCWCW2 convert rfc822-to-8bit (ORCPT ); Sun, 22 Mar 2015 22:22:28 -0400 X-AuditID: cbfee68d-f79296d000004278-15-550f78e25bb8 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <550F78E1.8050006@samsung.com> Date: Mon, 23 Mar 2015 11:22:25 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 To: Rob Herring Cc: Bryan Wu , Richard Purdie , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Sakari Ailus , Jacek Anaszewski , Varka Bhadram , sw0312.kim@samsung.com, Chanwoo Choi , Jaehoon Chung , Inha Song , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-leds@vger.kernel.org Subject: Re: [PATCH v3 2/3] leds: ktd2692: add device tree bindings for ktd2692 References: <1426829466-13559-1-git-send-email-ingi2.kim@samsung.com> <1426829466-13559-3-git-send-email-ingi2.kim@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42JZI2JSrPuogj/UoHUdj8XRnROZLK5/ec5q Mf/IOVaL/jcLWS12/b3PaHHu1UpGi96rzxktbvxqY7W4vGsOm8XWN+sYLZZev8hkMWH6WhaL 1r1H2C2+f/vGZrF711NWizP7V7JZzJj8ks3iZMccRgchjzXz1jB6XO7rZfLYOesuu8fK5V/Y PA5/XcjisWlVJ5vHnvk/WD36tqxi9Pi8SS6AM4rLJiU1J7MstUjfLoErY9aMS4wFG4Qrls0+ xdjA2M7fxcjJISFgItEw/RsLhC0mceHeejYQW0hgKaPEv6/ZMDXb368FquECik9nlNg1/yEr SIJXQFDix+R7QAkODmYBdYkpU3IhTBGJxp5ikApmAW2JZQtfM0O0PmCUWNK5gx2iVUvi1tnP YGNYBFQlpqzcD7aXTUBN4saKhUwgc0QFIiRuX+YECYsATf+2/DgbyBxmgbWsEtPmrGMCSQgL +EtMW9vBBrHgBKNE19wjYAs4BYIlFq68wAiSkBDYwyGxfMcWRohtAhLfJh8CO1pCQFZi0wFm iCclJQ6uuMEygVF8FpLXZiG8NgvhtVlIXlvAyLKKUTS1ILmgOCm9yFCvODG3uDQvXS85P3cT IzBtnP73rHcH4+0D1ocYBTgYlXh4O+L4Q4VYE8uKK3MPMZoC3TORWUo0OR+YnPJK4g2NzYws TE1MjY3MLc2UxHkVpX4GCwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamB0N7H78ZUp7Y7oVqFf ExQY24/bvf+w7aNqYWSqhHjFh2nGJySsK5X0+LWicj6+efarxzKnJ43h0OfILMmFr6MTrtq/ 565fVGe68ch+l8zTq45vcI8U462VubtHW7tAyNR6HnvyLpEeE+WY+b+s0sM3x0VrCEmUntut 1cfspLla7fmjF1+PTFRiKc5INNRiLipOBADWCLN2FgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGKsWRmVeSWpSXmKPExsVy+t9jQd1HFfyhBrt3MFkc3TmRyeL6l+es FvOPnGO16H+zkNVi19/7jBbnXq1ktOi9+pzR4savNlaLy7vmsFlsfbOO0WLp9YtMFhOmr2Wx aN17hN3i+7dvbBa7dz1ltTizfyWbxYzJL9ksTnbMYXQQ8lgzbw2jx+W+XiaPnbPusnusXP6F zePw14UsHptWdbJ57Jn/g9Wjb8sqRo/Pm+QCOKMaGG0yUhNTUosUUvOS81My89JtlbyD453j Tc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgF5SUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesb EgTXY2SABhLWMGZs/7acpWCScMWN07MZGxhf8nUxcnJICJhIbH+/lgXCFpO4cG89WxcjF4eQ wHRGiV3zH7KCJHgFBCV+TL4HVMTBwSwgL3HkUjaEqS4xZUouRPkDRoklnTvYIcq1JG6d/QzW yiKgKjFl5X42EJtNQE3ixoqFTCC9ogIRErcvc4KERYDGfFt+HGwts8BaVolpc9YxgSSEBfwl pq3tgLrnBKNE19wjYAs4BYIlFq68wDiBUWAWkvNmIZw3C+G8BYzMqxhFUwuSC4qT0nMN9YoT c4tL89L1kvNzNzGC08wzqR2MKxssDjEKcDAq8fA2hPOHCrEmlhVX5h5ilOBgVhLhjbUHCvGm JFZWpRblxxeV5qQWH2I0BXpuIrOUaHI+MAXmlcQbGpuYGVkamRtaGBmbK4nzKtm3hQgJpCeW pGanphakFsH0MXFwSjUwdt7WLXsnxbTjNuP6F1fOa/5KmDWh+9qdo1dXzjtqs0L4YGd9xASX q6sO9z26v9+z4ObrZbVau+ovv7b/acVg8Oh0refVFWyh2i8KlFiusS/667l0hjPXTq0PZ6cf OlctVcnbaVd2PnhN2ofqIEeRsN+uNpyqvOLLmkWUbq5OmF60fktavvK8bUosxRmJhlrMRcWJ AHKzBIVJAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Rob On 2015년 03월 21일 00:49, Rob Herring wrote: > On Fri, Mar 20, 2015 at 12:31 AM, Ingi Kim wrote: >> This patch adds the device tree bindings for ktd2692 flash LEDs. >> Add optional properties 'flash-timeout-us' to control flash timeout >> and 'vin-supply' for flash-led regulator >> >> Signed-off-by: Ingi Kim >> --- >> .../devicetree/bindings/leds/leds-ktd2692.txt | 34 ++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> new file mode 100644 >> index 0000000..75e16f8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt >> @@ -0,0 +1,34 @@ >> +* Kinetic Technologies - KTD2692 Flash LED Driver >> + >> +KTD2692 is the ideal power solution for high-power flash LEDs. >> +It uses ExpressWire single-wire programming for maximum flexibility. >> + >> +The ExpressWire interface through CTRL pin can control LED on/off and >> +enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, >> +Flash timeout, LVP(low voltage protection). >> + >> +Also, When the AUX pin is pulled high while CTRL pin is high, >> +LED current will be ramped up to the flash-mode current level. >> + >> +Required properties: >> + - compatible: "kinetic,ktd2692" >> + - ctrl-gpio, aux-gpio : gpio pin in order control ktd2692 flash led. >> + There is an internal 300kOhm pull-down resistor at each pin >> + - supply : "vin" LED supply (2.7V to 5.5V) > > This should be "vin-supply", right? > Yes, You are right. "vin-supply" is more exact than before. I'll fix it Thanks >> + See Documentation/devicetree/bindings/regulator/regulator.txt >> + >> +Optional property: >> + - flash-timeout-us : Maximum flash timeout in microseconds. >> + flash timeout ranges from 0 to 1835000us and >> + default is 1049000us. >> + >> +Example: >> + >> +flash-led { >> + compatible = "kinetic,ktd2692"; >> + ctrl-gpio = <&gpc0 1 0>; >> + aux-gpio = <&gpc0 2 0>; >> + flash-timeout-us = <1835000>; >> + vin-supply = <&vbat>; >> +}; >> + >> -- >> 2.0.5 >> >